Skip to content

fix: project-settings-export-import-missing #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zaimwa9 merged 1 commit into from
Dec 1, 2025
Merged

fix: project-settings-export-import-missing #6343

Zaimwa9 merged 1 commit into from
Dec 1, 2025

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Dec 1, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Migrating from store to RTK only lacked the environments (and typing hinted that it was there)
  • useless confusing environmentID prop in ImportPage
  • Removed them and properly get the environment lists

How did you test this code?

  • Exported and re-imported environments
image image image image image image image

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner December 1, 2025 10:04
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team December 1, 2025 10:04
@vercel
Copy link

vercel bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Comment Dec 1, 2025 10:04am
flagsmith-frontend-staging Ready Ready Preview Comment Dec 1, 2025 10:04am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Dec 1, 2025 10:04am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6343 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6343 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6343 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-6343 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6343 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-6343 Finished ✅ Results ✅

matthewelwell
matthewelwell approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a manual test

@Zaimwa9 Zaimwa9 merged commit fc22a05 into main Dec 1, 2025
27 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/import-export-disabled branch December 1, 2025 10:37
@flagsmithdev flagsmithdev mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talissoncosta talissoncosta talissoncosta approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zaimwa9 @talissoncosta @matthewelwell