Skip to content

fix: add pylon selector to hidden on modal #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kyle-ssg merged 1 commit into from
Nov 18, 2025
Merged

fix: add pylon selector to hidden on modal #6299

kyle-ssg merged 1 commit into from
Nov 18, 2025

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 18, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Hides Pylon on modal open just like crisp. Note: we still do have Crisp code and this should be removed if/when we deprecate the Pylon feature flag.

How did you test this code?

Open modal

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 18, 2025 10:41
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team November 18, 2025 10:41
@vercel
Copy link

vercel bot commented Nov 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Comment Nov 18, 2025 10:43am
flagsmith-frontend-staging Ready Ready Preview Comment Nov 18, 2025 10:43am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Nov 18, 2025 10:43am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Nov 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6299 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6299 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6299 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-6299 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6299 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-6299 Finished ✅ Results ✅

@kyle-ssg kyle-ssg merged commit e643d78 into main Nov 18, 2025
26 checks passed
@kyle-ssg kyle-ssg deleted the fix/hide-pylon-on-modals branch November 18, 2025 11:14
@flagsmithdev flagsmithdev mentioned this pull request Nov 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kyle-ssg @Zaimwa9