Skip to content

fails to build with libyang 4.2.2 #20243

@daniel-baumann

Description

@daniel-baumann

Description

Hi,

frr 10.5.0 fails to build with libyang 4.2.2. There are two issues in need to be fixed.

  1. the LYD_PRINT_WITHSIBLINGS yang flag was renamed to LYD_PRINT_SIBLINGS.

I've added the following patch to fix that: https://forgejo.debian.net/frr/frr/raw/branch/debian/debian/patches/debian/0001-libyang-4.patch

  1. it seems the type of dflt changed, the error message is as following:
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -DCONFDATE=0 -I. -I..  -I../lib/assert -I.. -I../include -I../lib -I. -I/usr/include/l
ua5.4   -Wdate-time -D_FORTIFY_SOURCE=2 -fms-extensions -fno-omit-frame-pointer -funwind-tables -Wall -Wextra -Wformat-nonliteral -Wformat-security -Wswi
tch-enum -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wundef -Wimplicit-fallthrou
gh -Wshadow -Wmissing-noreturn -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wno-error=deprecated-declarations    -I/usr/incl
ude/x86_64-linux-gnu     -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/frr=. -fstack-protector-strong -fstack-clash-protection -W
format -Werror=format-security -fcf-protection -c -o lib/pullwr.lo ../lib/pullwr.c                                                                       
../lib/northbound.c: In function ‘nb_cb_operation_is_valid’:                                                                                             
../lib/northbound.c:2302:29: error: invalid operands to binary || (have ‘int’ and ‘struct lysc_value’)                                                   
 2302 |                             || sleaf->dflt)                                                                                                      
      |                             ^~ ~~~~~~~~~~~                                                                                                       
      |                                     |                                                                                                            
      |                                     struct lysc_value                                                                                            

Version

10.5.0

How to reproduce

build 10.5.0 with libyang 4.2.2

Expected behavior

it shoudn't fail to build from source.

Actual behavior

it fails to build from source.

Additional context

No response

Checklist

  • I have searched the open issues for this bug.
  • I have not included sensitive information in this report.

Metadata

Metadata

Assignees

Labels

triageNeeds further investigation

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions