Disable PA in TXRXdisable() whether in rx_enable or tx_enable state for esp8285#3485
Merged
pkendall64 merged 1 commit intoExpressLRS:3.x.x-maintenancefrom Jan 11, 2026
Merged
Conversation
Signed-off-by: ncerzzk <[email protected]>
Ncerzzk
changed the title
pkendall64
approved these changes
Jan 10, 2026
mha1
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
For now, we only disable PA in tx_enable state in 8285.
This patch disable PA in all situation when call TXRXdisable.
And Why to do this change:
Actually I'm making a RX hardware which could let esp8285 use SX1280's antenna by a RF switch.
(I'm fed up with the terrible Wi-Fi signal in current ESP8285 hardware because I often use
the msp2wifi function to configure INav FC)
and I try to find a PIN which could control the RF Switch when wifi enable, PA_ENABLE is fitable.
and I find the PA_ENABLE never be lower when in rx_enable state, so do this change.
On the other hand, to keep the behavior consistency with esp32 and esp32C3, we should also do it.
Thank you! feel free to comment.