TFT/OLED reorder packet rates for LR1121#3468
Conversation
pkendall64
left a comment
There was a problem hiding this comment.
Hmmm, theres got to be a better way than having this list in different places with slight differences!
I did think the same thing, like maybe we can just use the lua strings and parse them on the fly for the display module instead of having separate lists. This would probably be better if we could make it two stage, like the lua has SubG/2.4/XBand as well. I'm also not sure if there's an interaction with setting the packet rate via the Crotch TV, then going into the lua the static band variable isn't updated to reflect the new packet rate. It is a bit of a problem with two completely separate bits of code that are doing the same thing but two different ways. :/ Or we could do I didn't want to mess too much with it for 4.0, and also I do not have an LR1121 module with a display for development/testing. I tested this just flashing the Corewing Sirius with S3-LR1121 firmware just so I could see the menu in action, but trying to change the value just core dumps haha. |
|
Definitely not for 4.0! Maybe something we can think about cleaning up for 4.1 or later. |
In the TFT/OLED menu the Packet Rate menu still used the old 3.x order for LR1121 radios
Reported by dakefpv on the discord private channel