changing method signature/using forAddress

vineet-belur · vineet-belur · commit a57fb6e4379a · 2025-03-18T10:45:49.000-05:00
diff --git a/java/serving-client/src/main/java/dev/feast/FeastClient.java b/java/serving-client/src/main/java/dev/feast/FeastClient.java
@@ -92,7 +92,7 @@ public static FeastClient createSecure(String host, int port, SecurityConfig sec
   }
 
   /**
-   * Create an authenticated client to access Feast Serving.
+   * Create an authenticated client to access Feast Serving with HTTP config values.
    *
    * @param url URL of Feast serving GRPC server
    * @param securityConfig security options to configure the Feast client. See {@link
@@ -101,13 +101,14 @@ public static FeastClient createSecure(String host, int port, SecurityConfig sec
    * @param serviceConfig see https://grpc.io/docs/guides/service-config/
    * @return {@link FeastClient}
    */
-  public static FeastClient createSecureWithTarget(
+  public static FeastClient createSecure(
       String url,
+      int port,
       SecurityConfig securityConfig,
       long requestTimeout,
       Map<String, Object> serviceConfig) {
     NettyChannelBuilder nettyChannelBuilder =
-        NettyChannelBuilder.forTarget(url).defaultServiceConfig(serviceConfig);
+        NettyChannelBuilder.forAddress(url, port).defaultServiceConfig(serviceConfig);
 
     if (securityConfig.isTLSEnabled()) {
       nettyChannelBuilder.useTransportSecurity();
@@ -128,7 +129,7 @@ public static FeastClient createSecureWithTarget(
    * @return {@link FeastClient}
    */
   public static FeastClient createSecure(
-      String host, int port, SecurityConfig securityConfig, long requestTimeout, Optional<Map<String, Object>> serviceConfig) {
+      String host, int port, SecurityConfig securityConfig, long requestTimeout) {
 
     if (requestTimeout < 0) {
       throw new IllegalArgumentException("Request timeout can't be negative");
@@ -146,7 +147,6 @@ public static FeastClient createSecure(
               NettyChannelBuilder.forAddress(host, port)
                   .useTransportSecurity()
                   .sslContext(GrpcSslContexts.forClient().trustManager(certificateFile).build())
-                  .defaultServiceConfig(serviceConfig.get())
                   .build();
         } catch (SSLException e) {
           throw new IllegalArgumentException(
