Open
Conversation
Remove all the labels and logs that surface parameterized query arguments, because doing so severely impacts performance due to the use of github.com/kr/pretty and because parameterized query arguments often contain sensitive data.
bhcleek
force-pushed
the
remove-args-label
branch
from
8b2d061 to
bfe9c0a
Compare
|
Hey there, https://github.com/luna-duclos/instrumentedsql has an Option already to disable query argument logging. Please have a look and let me know if it's sufficient. |
Author
|
It looks like that will nearly be sufficient. The query args in prepared statements don't leverage the option, though. Is that an oversight or intentional?. Is your fork the new canonical repository instead of this one? |
|
I'll happily accept a PR to fix the prepared statement issue. |
|
IMHO, this needs to be an option of the driver. The user can chose whether to print args or not... |
slagiewka
pushed a commit
to slagiewka/instrumentedsql
that referenced
this pull request
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all the labels and logs that surface parameterized query
arguments, because doing so severely impacts performance due to the use
of github.com/kr/pretty and because parameterized query arguments often
contain sensitive data.
Because parameterized query arguments often contain sensitive data (passwords, api tokens, etc.) or highly regulated data (e.g. HIPAA, GDPR, et al), it's generally a good idea to not log them.