Update the README. Fixes grammar mistakes, adjusts examples to better…#7
Update the README. Fixes grammar mistakes, adjusts examples to better…#7cmcculloh-kr merged 5 commits intoExactTarget:masterfrom
Conversation
… conform with guide, and removes non relevant pieces.
|
@cmcculloh Hey, could you take a look at this? Largely it is grammatical, and fixes a few issues where the examples don't conform with the style guide. |
README.md
Outdated
There was a problem hiding this comment.
The space is required. Having a space between function and () helps to indicate that "function" is not the name of the function, and that this is an un-named anonymous function.
|
Thanks @gdborton! I liked a lot of these changes, but had a few concerns. |
|
@cmcculloh Thanks for the feedback, I think I responded to everything. It's awesome that you're so thorough. |
README.md
Outdated
There was a problem hiding this comment.
@cmcculloh added this back in here. Also, corrected anonymous functions throughout the readme.
|
Awesome @gdborton, thanks! This all looks good to me. Thank you for your work! I'm going to give this until Monday for any of the other UXAs to weigh in before merging. |
|
@cmcculloh Updated the anonymous functions to include a space before the paren (was some confusion on my part). Also fix the missing semicolon. |
|
One last thing and I'll merge. Thanks! |
|
Updated. |
Update the README. Fixes grammar mistakes, adjusts examples to better…
|
Thank you sir!!! |
4 participants
… conform with guide, and removes non relevant pieces.