This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Add jscs lint configuration.#6
Merged
cmcculloh-kr merged 1 commit intoExactTarget:masterfrom Jun 5, 2015
Merged
Conversation
|
Thanks! I don't see this one listed. Is it just on by default? Or was that a miss? |
Contributor
Author
|
Some of the rules are more general that others. function a (){
};
var b = function (){
};Both will fail the rule Their docs aren't super clear on how the precedence occurs. |
Contributor
Author
|
@cmcculloh any other feedback on this? Might have another pull coming in afterward that would cause some merge issues. |
Contributor
Author
|
bueller? |
|
Sorry, I kept meaning to look into this. The proper syntax is: function a() {
};
function () {
};I just need you to confirm that it does the right thing for that. |
Contributor
Author
|
Yep, it's covered. |
cmcculloh-kr
pushed a commit
that referenced
this pull request
Jun 5, 2015
Add jscs lint configuration.
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see the airbnb rules here
The full rule list here
preset === follow their rules other than listed exceptions.
Exception reasoning-