-
Notifications
You must be signed in to change notification settings - Fork 45
TTL Heap implementation #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Notes:
|
|
FYI, probably gonna hold off and refactor this after #164 gets done. |
|
I believe I found the root cause to the issue with this PR. However, from what I understand, a deletion request is also sent to the leader node. I believe this request specifically is what's causing the response to get hung up. This causes a deadlock because in SugarDB.evictKeysWithExpiredTTL() we have to engage the storeLock as well as the keysWithExpiry lock. BUT these two locks are engaged in the HandlerFuncParams.DeleteKey() function. This seems to be a catch 22, since these locks are needed in both places. |

This PR addresses #151.