Skip to content

fix: Remove dodal from default application config#1573

Merged
abbiemery merged 3 commits into
mainfrom
remove-dodal-defaults
Jun 26, 2026
Merged

fix: Remove dodal from default application config#1573
abbiemery merged 3 commits into
mainfrom
remove-dodal-defaults

Conversation

@abbiemery

Copy link
Copy Markdown
Contributor

The default application still included dodal plans as a default. With the change to remove this dependency from the default application this would cause the server to error when trying to fetch plans. This replaces those defaults with an empty list.

@abbiemery abbiemery requested a review from a team as a code owner June 26, 2026 10:10
@abbiemery abbiemery changed the title fix: Remove dodal defaults from application config fix: Remove dodal from default application config Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.91%. Comparing base (8d585a9) to head (65a3b9d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1573   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          44       44           
  Lines        3255     3255           
=======================================
  Hits         3122     3122           
  Misses        133      133           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/blueapi/config.py
@abbiemery abbiemery added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 7622ee0 Jun 26, 2026
21 checks passed
@abbiemery abbiemery deleted the remove-dodal-defaults branch June 26, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants