Skip to content

fix: add missing values ApplicationConfig equality check#1565

Merged
ZohebShaikh merged 2 commits into
mainfrom
add-blueapi-config-checks
Jun 25, 2026
Merged

fix: add missing values ApplicationConfig equality check#1565
ZohebShaikh merged 2 commits into
mainfrom
add-blueapi-config-checks

Conversation

@ZohebShaikh

@ZohebShaikh ZohebShaikh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Currently the following configs are not checked for equality

@ZohebShaikh ZohebShaikh requested a review from a team as a code owner June 25, 2026 10:34
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.91%. Comparing base (50fd3dd) to head (fc7fe04).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1565   +/-   ##
=======================================
  Coverage   95.90%   95.91%           
=======================================
  Files          44       44           
  Lines        3250     3255    +5     
=======================================
+ Hits         3117     3122    +5     
  Misses        133      133           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/blueapi/config.py Outdated
Comment thread src/blueapi/config.py
@ZohebShaikh ZohebShaikh added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit 8404420 Jun 25, 2026
19 checks passed
@ZohebShaikh ZohebShaikh deleted the add-blueapi-config-checks branch June 25, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants