refactor: Stop DeviceRef extending str#1557
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
=======================================
Coverage 95.86% 95.87%
=======================================
Files 44 44
Lines 3292 3298 +6
=======================================
+ Hits 3156 3162 +6
Misses 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
I did a quick test with this, seems to work >>> devs.fsj1.
devs.fsj1.model devs.fsj1.name No more unrelated methods. Tried some move plans. >>> plans.set_absolute(devs.fsj1, "Out")
>>> plans.set_absolute(devs.fsj1, "In")
>>> plans.set_absolute(devs.smpm.x, 1)
>>> plans.set_absolute(devs.smpm.x, 5)
>>> pl.move({dv.fsj1: "In"})
>>> |
This was originally to make serialization behave correctly when the task was passed to requests. As we are using pydantic to dump the model to JSON before passing it, we can add the custom serialization there to get the device-to-string conversion that we need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally to make serialization behave correctly when the task
was passed to requests. As we are using pydantic to dump the model to
JSON before passing it, we can add the custom serialization there to get
the device-to-string conversion that we need.