Fix missign boolean type & wrong docs#75104
Conversation
|
@sosoba Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75104,
"author": "sosoba",
"headCommitOid": "3f37771a0dfe76cbfa722066c0df19247178f837",
"mergeBaseOid": "33db4a4473f66b2cbd8969547f1c7448d0e76da8",
"lastPushDate": "2026-06-10T07:07:33.000Z",
"lastActivityDate": "2026-06-10T10:33:05.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "oracledb",
"kind": "edit",
"files": [
{
"path": "types/oracledb/index.d.ts",
"kind": "definition"
}
],
"owners": [
"connorjayfitzgerald",
"dannyb648",
"jacobwheale",
"sudarshan12s",
"sharadraju"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sudarshan12s",
"date": "2026-06-10T10:33:05.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 4667551982,
"ciResult": "pass"
} |
typescript-automation
Bot
added
Critical package
Untested Change
|
Hey @sosoba, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
typescript-automation
Bot
moved this to Waiting for Code Reviews
in Pull Request Status Board
|
🔔 @connorjayfitzgerald @dannyb648 @jacobwheale @sudarshan12s @sharadraju — please review this PR in the next few days. Be sure to explicitly select |
typescript-automation
Bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
typescript-automation
Bot
moved this from Needs Maintainer Review
to Waiting for Code Reviews
in Pull Request Status Board
typescript-automation
Bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
sudarshan12s
left a comment
sudarshan12s
left a comment
There was a problem hiding this comment.
Thanks for the changes.
typescript-automation
Bot
added
the
Owner Approved
2 participants
Please fill in this template.
pnpm test <package to test>.rowsAffected is missing for "SELECT FOR UPDATE" queries (contrary to documentation) oracle/node-oracledb#1280
https://node-oracledb.readthedocs.io/en/latest/release_notes.html#node-oracledb-v6-0-0-24-may-2023 (point 7.4)
package.json.