Types for eslint-plugin-github, eslint-plugin-no-constructor-bind, eslint-plugin-no-unsanitized, eslint-plugin-pii, eslint-plugin-redos, eslint-plugin-xss#75085
Conversation
|
@Simbiat Thank you for submitting this PR! This is a live comment that I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 6 packages in this PR (and infra files)
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75085,
"author": "Simbiat",
"headCommitOid": "cc71f954ede416cbf0868071856b424b674348ac",
"mergeBaseOid": "ca65e20b1c0aba452e9be1407798945801c758f5",
"lastPushDate": "2026-06-06T17:16:24.000Z",
"lastActivityDate": "2026-06-06T18:26:33.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "package.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
},
{
"name": "eslint-plugin-github",
"kind": "add",
"files": [
{
"path": "types/eslint-plugin-github/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-github/eslint-plugin-github-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-plugin-github/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-plugin-github/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-github/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Simbiat"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "eslint-plugin-no-constructor-bind",
"kind": "add",
"files": [
{
"path": "types/eslint-plugin-no-constructor-bind/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-no-constructor-bind/eslint-plugin-no-constructor-bind-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-plugin-no-constructor-bind/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-plugin-no-constructor-bind/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-no-constructor-bind/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Simbiat"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "eslint-plugin-no-unsanitized",
"kind": "add",
"files": [
{
"path": "types/eslint-plugin-no-unsanitized/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-no-unsanitized/eslint-plugin-no-unsanitized-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-plugin-no-unsanitized/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-plugin-no-unsanitized/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-no-unsanitized/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Simbiat"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "eslint-plugin-pii",
"kind": "add",
"files": [
{
"path": "types/eslint-plugin-pii/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-pii/eslint-plugin-pii-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-plugin-pii/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-plugin-pii/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-pii/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Simbiat"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "eslint-plugin-redos",
"kind": "add",
"files": [
{
"path": "types/eslint-plugin-redos/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-redos/eslint-plugin-redos-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-plugin-redos/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-plugin-redos/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-redos/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Simbiat"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "eslint-plugin-xss",
"kind": "add",
"files": [
{
"path": "types/eslint-plugin-xss/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-xss/eslint-plugin-xss-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-plugin-xss/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-plugin-xss/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-xss/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"Simbiat"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 4639815793,
"ciResult": "pass"
} |
typescript-bot
added
New Definition
|
🔔 @Simbiat — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@Simbiat The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in Pull Request Status Board
typescript-bot
added
Edits Infrastructure
and removed
The CI failed
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in Pull Request Status Board
|
@Simbiat The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in Pull Request Status Board
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in Pull Request Status Board
|
@Simbiat The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in Pull Request Status Board
|
@Simbiat The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in Pull Request Status Board
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Action
in Pull Request Status Board
typescript-bot
moved this from Needs Maintainer Action
to Waiting for Code Reviews
in Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Action
in Pull Request Status Board
|
Sorry for multiple attempts at CI. When I setup the repo locally it kept failing the tests not recognizing the original plugins no matter how I installed them (that also caused accidental commit of modified package.json). I prepared the types similar to how they were done in #75007 and IDE and ESLint did not seem to find anything obviously wrong. But now everything should be fixed. |
2 participants
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.