Yauzl: add missing 3.x API exports#75035
Open
anatoliishakhov wants to merge 1 commit into
Open
Conversation
- Add type definitions for getFileNameLowLevel, parseExtraFields, LocalFileHeader, readLocalFileHeader, and openReadStreamLowLevel - Add raw Buffer properties (fileNameRaw, fileCommentRaw, extraFieldRaw) to Entry - Update getLastModDate to accept options parameter - Update tests
Contributor
|
@anatoliishakhov Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75035,
"author": "anatoliishakhov",
"headCommitOid": "ecf3e5242cdc620ee3e70c8b3d7e8f26a31b2c7a",
"mergeBaseOid": "70c44e00c1164037ab55e42696e47700cda6bffc",
"lastPushDate": "2026-05-21T10:09:52.000Z",
"lastActivityDate": "2026-06-10T19:07:05.000Z",
"hasMergeConflict": true,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "yauzl",
"kind": "edit",
"files": [
{
"path": "types/yauzl/index.d.ts",
"kind": "definition"
},
{
"path": "types/yauzl/yauzl-tests.ts",
"kind": "test"
}
],
"owners": [
"ffflorian"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2026-06-01T16:42:02.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "ffflorian",
"date": "2026-05-21T12:00:33.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 4507077060,
"ciResult": "pass"
} |
Contributor
|
🔔 @ffflorian — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
typescript-bot
added
the
Owner Approved
Author
|
@typescript-bot this PR is ready to merge |
Collaborator
|
@anatoliishakhov we have to wait for a maintainer approval. |
Collaborator
|
ping @jakebailey |
typescript-bot
added
the
Unreviewed
Contributor
|
Re-ping : This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
jakebailey
approved these changes
Jun 1, 2026
typescript-bot
added
Maintainer Approved
Self Merge
typescript-bot
moved this from Needs Maintainer Review
to Waiting for Author to Merge
in Pull Request Status Board
Collaborator
|
Thanks @jakebailey! 🙂 |
typescript-bot
added
Has Merge Conflict
typescript-bot
moved this from Waiting for Author to Merge
to Needs Author Action
in Pull Request Status Board
Contributor
|
@anatoliishakhov Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
Collaborator
|
@anatoliishakhov will you fix the merge conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.