Skip to content

Bump version of html-to-text from 9 to 10#75034

Open
jreitz-voffice wants to merge 2 commits into
DefinitelyTyped:masterfrom
jreitz-voffice:chore/update-html-to-text
Open

Bump version of html-to-text from 9 to 10#75034
jreitz-voffice wants to merge 2 commits into
DefinitelyTyped:masterfrom
jreitz-voffice:chore/update-html-to-text

Conversation

@jreitz-voffice

Copy link
Copy Markdown

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

If changing an existing definition:

Maintenance release, should resolve some compatibility issues. Requirements upped to Node.js 20.19.0 and ES2022.

  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot

typescript-bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

@jreitz-voffice Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 9 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75034,
  "author": "jreitz-voffice",
  "headCommitOid": "cd452f4d46d2aa4f1a5d2b0f20a1c239dd57378b",
  "mergeBaseOid": "70c44e00c1164037ab55e42696e47700cda6bffc",
  "lastPushDate": "2026-05-21T08:53:09.000Z",
  "lastActivityDate": "2026-06-01T05:44:42.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "html-to-text",
      "kind": "edit",
      "files": [
        {
          "path": "types/html-to-text/html-to-text-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/html-to-text/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "erykwarren",
        "CarsonF",
        "webstech"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "webstech",
      "date": "2026-06-01T05:44:42.000Z"
    },
    {
      "type": "approved",
      "reviewer": "CarsonF",
      "date": "2026-05-21T18:04:57.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4506435125,
  "ciResult": "pass"
}

@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @erykwarren @CarsonF @webstech — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board May 21, 2026
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 21, 2026

console.log("\nProcessing string with default options");
console.log(htmlToText(htmlString));
htmlToText("<p>Hello</p>");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change for?

"private": true,
"name": "@types/html-to-text",
"version": "9.0.9999",
"version": "10.0.9999",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want it to match the html-to-text version, shouldn't the new version be the same?

@webstech webstech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain the purpose of the change and what it fixes. I do not have any issues using the old version with the latest version of html-to-text.

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Owner Approved A listed owner of this package signed off on the pull request. labels Jun 1, 2026
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in Pull Request Status Board Jun 1, 2026
@typescript-bot

Copy link
Copy Markdown
Contributor

@jreitz-voffice One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Revision needed This PR needs code changes before it can be merged.

Projects

Status: Needs Author Action

Development

Successfully merging this pull request may close these issues.

4 participants