[eslint-plugin-promise] add types#75007
Conversation
|
@JoshuaKGoldberg Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75007,
"author": "JoshuaKGoldberg",
"headCommitOid": "2499e7b9030c4e6ffedf026c25e210002f7c13d0",
"mergeBaseOid": "ca06abb4cc3399ea070c122be329a22f1c3b6800",
"lastPushDate": "2026-05-15T12:32:39.000Z",
"lastActivityDate": "2026-05-16T11:24:48.000Z",
"mergeOfferDate": "2026-05-16T01:09:50.000Z",
"mergeRequestDate": "2026-05-16T11:24:48.000Z",
"mergeRequestUser": "JoshuaKGoldberg",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "eslint-plugin-promise",
"kind": "add",
"files": [
{
"path": "types/eslint-plugin-promise/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-promise/eslint-plugin-promise-tests.ts",
"kind": "test"
},
{
"path": "types/eslint-plugin-promise/index.d.ts",
"kind": "definition"
},
{
"path": "types/eslint-plugin-promise/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/eslint-plugin-promise/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"JoshuaKGoldberg"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2026-05-16T01:09:12.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 4459782840,
"ciResult": "pass"
} |
typescript-bot
added
the
New Definition
|
🔔 @JoshuaKGoldberg — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Action
in Pull Request Status Board
typescript-bot
added
Maintainer Approved
Self Merge
typescript-bot
moved this from Needs Maintainer Action
to Waiting for Author to Merge
in Pull Request Status Board
|
@JoshuaKGoldberg: Everything looks good here. I am ready to merge this PR (at 2499e7b) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
typescript-bot
moved this from Waiting for Author to Merge
to Recently Merged
in Pull Request Status Board
3 participants
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.Pending eslint-community/eslint-plugin-promise#488.