[@types/node] node:test describe/suite/test/it and their variants don't return Promise<void> anymore.#73062
Conversation
|
@alcuadrado Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 73062,
"author": "alcuadrado",
"headCommitOid": "83804358b548bc466626a05d38843f311b8de0b5",
"mergeBaseOid": "b8294fd153083d1334ecb2b340be68687cef4cd5",
"lastPushDate": "2025-06-18T23:34:29.000Z",
"lastActivityDate": "2025-06-18T23:52:45.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/test.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky",
"Renegade334"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "Renegade334",
"date": "2025-06-18T23:52:45.000Z"
}
],
"mainBotCommentID": 2986063150,
"ciResult": "pass"
} |
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
This change is pending rapid reversion (nodejs/node#58282) and has been omitted from @types/node for that reason.
typescript-bot
added
the
Revision needed
typescript-bot
moved this from Needs Maintainer Review
to Needs Author Action
in Pull Request Status Board
|
@alcuadrado One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
Closing as that change was reverted :( |
4 participants
Hi,
This is my first PR into DefinitelyTyped. I hope I followed the instructions correctly. If not, please let me know.
This PR updates the definition of
@types/node'snode:testmodule. I believe this update is important, as it reflects a change introduced in Node 24. On top of that, this tests allows you to enable no-floating-promise intypescript-eslintfor your tests.Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.This change was announced with the release of Node.js 24.0.0: https://nodejs.org/en/blog/release/v24.0.0