Skip to content

[node] correct SlowBuffer#32661

Merged
armanio123 merged 1 commit into
DefinitelyTyped:masterfrom
Flarna:node-remove-slowbuffer-from-global
Feb 8, 2019
Merged

[node] correct SlowBuffer#32661
armanio123 merged 1 commit into
DefinitelyTyped:masterfrom
Flarna:node-remove-slowbuffer-from-global

Conversation

@Flarna

@Flarna Flarna commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

Removed SlowBuffer from global as it doesn't exist there.
Remove non existing constructors.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Jan 31, 2019
@typescript-bot

typescript-bot commented Jan 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Flarna Thank you for submitting this PR!

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @BrunoScheufler @smac89 @tellnes @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @matthieusieben @mohsen1 @n-e @octo-sniffle @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @jeremiergz @samuela @kuehlein - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

typescript-bot commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@Flarna

Flarna commented Jan 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sandersn Seems CI for node is broken again...

Error in ledgerhq__hw-transport
Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/ledgerhq__hw-transport/ledgerhq__hw-transport-tests.ts:6:1
ERROR: 6:1  expect  Expected type to be:
  Promise<ReadonlyArray<string>>
got:
  Promise<readonly string[]>
    at /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:161:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:5:58)
    at <anonymous>

Is this an expected change from typescript side? Maybe microsoft/TypeScript#29435?

@typescript-bot

typescript-bot commented Jan 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Flarna The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Feb 1, 2019
@typescript-bot

typescript-bot commented Feb 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Flarna The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@Flarna Flarna mentioned this pull request Feb 1, 2019
Closed
9 tasks
@typescript-bot

typescript-bot commented Feb 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Flarna The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@Flarna Flarna closed this Feb 7, 2019
@Flarna Flarna reopened this Feb 7, 2019
@armanio123 armanio123 merged commit 510f813 into DefinitelyTyped:master Feb 8, 2019
@typescript-bot

typescript-bot commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

I just published @types/[email protected] to npm.

@Flarna Flarna deleted the node-remove-slowbuffer-from-global branch February 8, 2019 06:54
@Flarna Flarna mentioned this pull request Feb 9, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Flarna @typescript-bot @armanio123