[ember] add Application/Engine#buildInstance()#28114
[ember] add Application/Engine#buildInstance()#28114jamescdavis wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@jamescdavis Thank you for submitting this PR! 🔔 @jedmao @bttf @dwickern @chriskrycho @theroncross @mfeckie @alexlafroscia @mike-north - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@jamescdavis The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
Build failure appears to be a regression in |
|
@jamescdavis The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
typescript-bot
added
the
Abandoned
|
@jamescdavis To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
|
A breaking change in TS 3.1 held up this PR. Should be good to review/merge after #28282 goes in |
3 participants
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition: