types/node/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @DeividasBakanas @kjin @alvis Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

@andrewstucki Please fix the failures indicated in the Travis CI log.

Closing because of PR build timeouts

Re-opening to re-run failed test because of PR build timeouts

I don't think that this is going to pass in travis due to the sheer number of type definitions that are affected by the definitions in types/node. The build is timing out while running the tests because it's going through pretty much every single test possible.

If I understand the node source code correct then exeFile allows also to specify windowsVerbatimArguments.

Looks like @Flarna is right. execFile doesn't override shell, so it should still be valid to pass in windowsVerbatimArguments. Updated.

so... wondering what to do with this given that the build can't possibly pass due to the fact that it requires testing 1211 packages and exceeds Travis's time limit for jobs every time it runs?

@andrewstucki I believe you can do something like:

Forking the repo, create the travis hook on your account, run the tests there and try to do another commit after that. Travis will be able to skip running the long tests if you have already run it through travis once.

@smac89 I enabled travis on my branch and am going to see if it can pass there, but seeing as there appears to be a global travis timeout of 50 mins for jobs and the CI build above was canceled at 49:57, I'm kind of doubtful that I can get the tests to pass there.

See #20308

@andrewstucki Please fix the failures indicated in the Travis CI log.

@RyanCavanaugh as mentioned multiple times, this relates to #20308 -- the build is timing out because of the fact that this is a change to one of the definitions for node which is a dependency of pretty much every other definition in this project. It's not possible to fix because Travis times out before it can finish testing every single type definition.

@Andy-MS noticed you resolved and merged #20185

Seeing as this is related because of the Travis timeouts and has sat here untouched for 2 weeks, think you could take a look? Otherwise I think I'm just going to close this PR soon as it looks like it's getting no attention.