update conda yaml: add pyside6 as conda dependency#3253
Open
deruyter92 wants to merge 2 commits intoDeepLabCut:mainfrom
Open
update conda yaml: add pyside6 as conda dependency#3253deruyter92 wants to merge 2 commits intoDeepLabCut:mainfrom
deruyter92 wants to merge 2 commits intoDeepLabCut:mainfrom
Conversation
This resolves a dll shadowing problem, since shared dlls are used between ffmpeg and pyside6
Collaborator
|
It seems that the PyPi version of 'ffmpeg' is a thin wrapper for python that assumes the binaries are already installed, which is why conda is in use there. I've seen a few packages use a different method, which is to pause when ffmpeg is not installed and ask whether to run a script to install the binaries; not sure if we should consider doing the same. |
Collaborator
|
Regarding the installation and the python wrapper : see here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #3252
Summary
The installation using our conda yaml can cause a dll shadowing problem on some machines if ffmpeg is installed via conda and pyside6 via pip (the conda-installed ffmpeg dll's are resolved first, but can have a mismatching version for pyside6). This issue of mixing conda and pip installations (for ffmpeg and pyside6) can be addressed by either installing both via pip or both via conda. This PR includes pyside6 as a conda dependency for users of the conda yaml file.
Notes: