Conversation
CI Test ResultsRun: #23666468155 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Failed Testsmusl-aarch64/debug / 21-librcaJob: View logs No detailed failure information available. Check the job logs. musl-amd64/debug / 17-librcaJob: View logs No detailed failure information available. Check the job logs. musl-aarch64/debug / 8-librcaJob: View logs No detailed failure information available. Check the job logs. musl-amd64/debug / 25-librcaJob: View logs No detailed failure information available. Check the job logs. musl-aarch64/debug / 17-librcaJob: View logs No detailed failure information available. Check the job logs. musl-aarch64/debug / 25-librcaJob: View logs No detailed failure information available. Check the job logs. musl-amd64/debug / 21-librcaJob: View logs No detailed failure information available. Check the job logs. musl-amd64/debug / 8-librcaJob: View logs No detailed failure information available. Check the job logs. musl-aarch64/debug / 11-librcaJob: View logs No detailed failure information available. Check the job logs. musl-amd64/debug / 11-librcaJob: View logs No detailed failure information available. Check the job logs. Summary: Total: 32 | Passed: 22 | Failed: 10 Updated: 2026-03-27 21:01:25 UTC |
What does this PR do?:
This PR is a scan-build (static analysis) warning cleanup. The changes span 29 files and fall into these categories:
Signed/unsigned comparison fixes (most of the work)
reservoirSampler.h)
Constructor initializer list ordering (fixes warnings about out-of-order init)
Type correctness
ODR / linkage fixes (functions defined in headers)
Dead code removal
Minor fixes
Motivation:
Code cleanup and improve maintainability.
Additional Notes:
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!