Draft
Conversation
CI Test ResultsRun: #23557709532 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-03-25 18:49:54 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds the data needed to reconstruct the span dependency graph to perform critical path analysis.
Changes:
Motivation:
The profiler links wall-clock and CPU samples to spans via spanId, showing where time is spent within each task. This answers which code is hot, but not which code contributes to request latency. Correctly attributing latency to the right spans requires knowing the dependency structure, which then allows identifying the critical path through it.
Critical path analysis requires two things: the span dependency DAG (parent-child edges between spans) and accurate span durations. With both, it is possible to reconstruct the critical path per request, attribute latency to the spans that actually determine it, and predict which operations would yield the most latency improvement if optimized.
Additional Notes:
How to test the change?:
critical_pathbranch), parse JFR, reconstruct span DAG and verify parent-child edgesFor Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!