Add command line args for description, title, labels and interactive mode#38
Merged
jehiah merged 1 commit intoApr 16, 2020
Merged
Conversation
jehiah
requested changes
Apr 15, 2020
jehiah
left a comment
jehiah
left a comment
Owner
There was a problem hiding this comment.
👍 LGTM, but i think we should also allow overriding settings; in LoadSettings can you code to os.Getenv("GITOPENPULL_TOKEN") etc so all config values can be set via environment varaible as well as git config values?
|
|
||
| func main() { | ||
| if len(os.Args) > 1 { | ||
| fmt.Printf("git-open-pull v%s %s\n", Version, runtime.Version()) |
Owner
There was a problem hiding this comment.
Can you add a --version argument?
Contributor
Author
oh yes - I felt like there was something I was forgetting, will add that now! |
Contributor
Author
|
@jehiah added option to get settings from env variables as a flag - let me know what you think! |
jehiah
requested changes
Apr 16, 2020
jehiah
approved these changes
Apr 16, 2020
dianaabishop
force-pushed
the
add-command-line-args-open-pull_12
branch
from
d188c2e to
201b1e3
Compare
…title, labels and interactive mode
dianaabishop
force-pushed
the
add-command-line-args-open-pull_12
branch
from
229d62e to
55f0301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to git-open-pull to do the following:
An example of a non-interactive command is: git open-pull --description-file="description.txt" --title="My PR title" --labels="label1, label2" --interactive=false
Interactive mode defaults to true so that current expected behavior continues as expected