refactor: refactor Split component#763
Merged
wewoor merged 10 commits intoDTStack:mainfrom Jun 17, 2022
Merged
Conversation
Collaborator
|
@yyllff PR 非常棒，然后描述稍微写一下， 新代码的单测、静态检查需要看看。我们尽快 Review |
Codecov Report
@@ Coverage Diff @@
## main #763 +/- ##
==========================================
+ Coverage 91.46% 91.64% +0.18%
==========================================
Files 191 191
Lines 5984 5866 -118
Branches 1440 1404 -36
==========================================
- Hits 5473 5376 -97
+ Misses 505 484 -21
Partials 6 6
Continue to review full report at Codecov.
|
wewoor
requested changes
Jun 16, 2022
Collaborator
|
|
mortalYoung
requested changes
Jun 16, 2022
Collaborator
Author
收到 已修复 麻烦再看下哈 |
mortalYoung
requested changes
Jun 16, 2022
wewoor
reviewed
Jun 17, 2022
Collaborator
|
+1 |
Collaborator
Author
|
好哒 明儿有时间我看一下 辛苦啦
…---- 回复的原邮件 ----
| 发件人 | ***@***.***> |
| 日期 | 2022年06月14日 21:58 |
| 收件人 | ***@***.***> |
| 抄送至 | ***@***.******@***.***> |
| 主题 | Re: [DTStack/molecule] refactor: refactor Split component (PR #763) |
@yyllff PR 非常棒，然后描述稍微写一下， 新代码的单测、静态检查需要看看。我们尽快 Review
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
重构Split组件，精简代码，优化DOM显示结构
Changes
How Has This Been Tested?
Checklist