make the extensions disposable

DSharpPlus · akiraveliara · Aug 11, 2024 · Jul 15, 2024 · Jul 18, 2024 · Jul 18, 2024
commit 154a3f564f314e9e24b2e2d1c84e521f272f4a2d
diff --git a/DSharpPlus.CommandsNext/CommandsNextExtension.cs b/DSharpPlus.CommandsNext/CommandsNextExtension.cs
@@ -24,7 +24,7 @@ namespace DSharpPlus.CommandsNext;
 /// <summary>
 /// This is the class which handles command registration, management, and execution.
 /// </summary>
-public class CommandsNextExtension
+public class CommandsNextExtension : IDisposable
 {
     private CommandsNextConfiguration Config { get; }
     private HelpFormatterFactory HelpFormatter { get; }

diff --git a/DSharpPlus.Interactivity/InteractivityExtension.cs b/DSharpPlus.Interactivity/InteractivityExtension.cs
@@ -16,7 +16,7 @@ namespace DSharpPlus.Interactivity;
 /// <summary>
 /// Extension class for DSharpPlus.Interactivity
 /// </summary>
-public class InteractivityExtension
+public class InteractivityExtension : IDisposable
 {
     internal readonly ConcurrentDictionary<Type, AsyncEvent> eventDistributor = [];
     internal IClientErrorHandler errorHandler;

diff --git a/DSharpPlus.VoiceNext/VoiceNextExtension.cs b/DSharpPlus.VoiceNext/VoiceNextExtension.cs
@@ -13,7 +13,7 @@ namespace DSharpPlus.VoiceNext;
 /// <summary>
 /// Represents VoiceNext extension, which acts as Discord voice client.
 /// </summary>
-public sealed class VoiceNextExtension
+public sealed class VoiceNextExtension : IDisposable
 {
     private VoiceNextConfiguration Configuration { get; set; }
 

diff --git a/DSharpPlus/Clients/DefaultEventDispatcher.cs b/DSharpPlus/Clients/DefaultEventDispatcher.cs
@@ -1,7 +1,7 @@
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.Linq;
+using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
 
 using DSharpPlus.EventArgs;
@@ -10,8 +10,6 @@
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
-using Handler = System.Func<DSharpPlus.DiscordClient, DSharpPlus.EventArgs.DiscordEventArgs, System.IServiceProvider, System.Threading.Tasks.Task>;
-
 namespace DSharpPlus.Clients;
 
 /// <summary>
@@ -40,6 +38,7 @@ ILogger<IEventDispatcher> logger
     }
 
     /// <inheritdoc/>
+    [AsyncMethodBuilder(typeof(PoolingAsyncValueTaskMethodBuilder))]
     public ValueTask DispatchAsync<T>(DiscordClient client, T eventArgs)
         where T : DiscordEventArgs
     {

diff --git a/obsolete/DSharpPlus.SlashCommands/SlashCommandsExtension.cs b/obsolete/DSharpPlus.SlashCommands/SlashCommandsExtension.cs
@@ -20,7 +20,7 @@ namespace DSharpPlus.SlashCommands;
 /// A class that handles slash commands for a client.
 /// </summary>
 [Obsolete("DSharpPlus.SlashCommands is obsolete. Please consider using the new DSharpPlus.Commands extension instead.")]
-public sealed partial class SlashCommandsExtension
+public sealed partial class SlashCommandsExtension : IDisposable
 {
     //A list of methods for top level commands
     private static List<CommandMethod> commandMethods { get; set; } = [];