System alert channel add#1588
Merged
akiraveliara merged 6 commits intoJul 17, 2023
Merged
Conversation
Member
|
This PR contains also the changes from #1587 |
Contributor
Author
|
idk how to do two differents PR |
Member
|
make a new branch |
Member
|
You should work on different branches on your fork if you want to make independent PRs |
Contributor
Author
|
Le ven. 7 juil. 2023 à 16:12, InF ***@***.***> a écrit :
make a new branch
—
Reply to this email directly, view it on GitHub
<#1588 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUJZBANRDBWZL23D6V75YJTXPAKMTANCNFSM6AAAAAA2BZJPZA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
i did
|
Contributor
Author
|
I feel like when I already have a pending PR, and I made another branch, the commits from that branch get added to my pending PR |
Member
|
because you did your changes on master branch |
Member
|
when you open a PR its a request to merge that branch to master. so when you use 2 branches and dont push to your master, it should work |
Contributor
Author
|
ok i see, so should i close these PR ?
Le ven. 7 juil. 2023 à 16:14, InF ***@***.***> a écrit :
… because you did your changes on master branch
—
Reply to this email directly, view it on GitHub
<#1588 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUJZBAJWEWWCIBIIYZ5KDSTXPAKVDANCNFSM6AAAAAA2BZJPZA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
i see thanks guys |
Member
|
i think it should be fine if you close the first and state all changes here |
Member
|
please don't merge multiple PRs into one. each PR should deal with one set of changes |
Plerx2493
pushed a commit
to Plerx2493/DSharpPlus
that referenced
this pull request
Jul 19, 2023
* SafetyAlertsChannel property added.
akiraveliara
added a commit
that referenced
this pull request
Aug 28, 2023
* Update AuditLogActionType * Cleanup var naming, minor refactors (ToArra to avoid multiple enumerations) * remove misclick * Update AuditLogActionType * Apply editorconfig * Apply editorconfig * Fix Typos and use new() * nuke old auditLog abstraction, add new Auditlogentry types and start full rewrite of Guild#GetAuditLogsAsync * Make PropertyChange a struct and start to split the auditlogentry parsing into AuditLogParser * fix indentation * Continue moving * Continue moving * Continue moving * The great moving * Add new Event and rename the GuildBan intent to GuildModeration (according to the discord docs) * init Event... * Fix caches for ResponsibleUser * Use the guild cache * Update data representation * Update data representation * Fix Permission updates * Add check to minimize api calls * Re-added a flag that I had deleted + headers formatting. (#1587) * Added missing flag, and remove useless flag * Added headers to Formatter.cs * Re-added a flag that I had deleted. * System alert channel add (#1588) * SafetyAlertsChannel property added. * Handle nullable safety alerts channel ID. (#1597) * fix: Use `DiscordJson` to deserialize GDMs * fix indentation * why are you running * Add missing parser methods * Finish last parsing Method * Add missing docs and formatting * Update and use thread cache * Rename autogenerated parameter * Update PropertyChange * Adding xmldocs, revert Intent renaming, update method return types * ups * Add toggleable logging * Great moving the 2nd * Fix missing init * Fix wrong casting and rename member * add missing key on threads and integration * add missing key on automod entries --------- Co-authored-by: P A T R I C K <[email protected]> Co-authored-by: Livia Silvercrown <[email protected]> Co-authored-by: Velvet Toroyashi <[email protected]>
OoLunar
pushed a commit
that referenced
this pull request
Oct 3, 2024
* SafetyAlertsChannel property added.
OoLunar
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Update AuditLogActionType * Cleanup var naming, minor refactors (ToArra to avoid multiple enumerations) * remove misclick * Update AuditLogActionType * Apply editorconfig * Apply editorconfig * Fix Typos and use new() * nuke old auditLog abstraction, add new Auditlogentry types and start full rewrite of Guild#GetAuditLogsAsync * Make PropertyChange a struct and start to split the auditlogentry parsing into AuditLogParser * fix indentation * Continue moving * Continue moving * Continue moving * The great moving * Add new Event and rename the GuildBan intent to GuildModeration (according to the discord docs) * init Event... * Fix caches for ResponsibleUser * Use the guild cache * Update data representation * Update data representation * Fix Permission updates * Add check to minimize api calls * Re-added a flag that I had deleted + headers formatting. (#1587) * Added missing flag, and remove useless flag * Added headers to Formatter.cs * Re-added a flag that I had deleted. * System alert channel add (#1588) * SafetyAlertsChannel property added. * Handle nullable safety alerts channel ID. (#1597) * fix: Use `DiscordJson` to deserialize GDMs * fix indentation * why are you running * Add missing parser methods * Finish last parsing Method * Add missing docs and formatting * Update and use thread cache * Rename autogenerated parameter * Update PropertyChange * Adding xmldocs, revert Intent renaming, update method return types * ups * Add toggleable logging * Great moving the 2nd * Fix missing init * Fix wrong casting and rename member * add missing key on threads and integration * add missing key on automod entries --------- Co-authored-by: P A T R I C K <[email protected]> Co-authored-by: Livia Silvercrown <[email protected]> Co-authored-by: Velvet Toroyashi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply added SystemAlertsChannel missing property to DiscordGuild.cs