Auditlog cleanup and update#1586
Conversation
|
i have not implemented a new type for the new actionTypes because i didnt know if we want to continue with this monster method |
|
The editorconfig is against using var. Should i replace it in all methods i clean up? its used everywhere |
|
please do, and if you can, also run other format rules like file-scoped namespaces |
|
@akiraveliara should i enforce all editorconfig warnings or only those which only affects files i already have changes in? |
|
There are several naming rules broken but they also make changes in DiscordClient.cs |
|
only in files you touch for now, so as to avoid huge merge conflicts |
|
ok i got it |
|
|
|
Now its a huge PR for a minor change ^^ |
|
you can always make the PR extend to more audit log functionality if you want (: |
|
but seriously, that's fine. it'll be a little annoying when it comes to reverting commits, but eh |
|
My plan is to implement the missing auditlogtypes. I will see what I can do after that |
…full rewrite of Guild#GetAuditLogsAsync
…sing into AuditLogParser
inftord
left a comment
inftord
left a comment
There was a problem hiding this comment.
more documentation required, but other than that LGTM
I haven't had a chance to check it yet, but I can look at it later. |
xml docs on the new methods or anything else? I have those in mind |
|
yes, xmldocs |
currently working on it |
|
Should be ready now |
|
Missing change keys: DiscordAuditLogAutoModerationRuleEntry:
DiscordAuditLogIntegrationEntry:
DiscordAuditLogThreadEventEntry:
|
|
once the change keys are added we can merge this as far as i'm concerned |
|
should be ready to merge |
* Update AuditLogActionType * Cleanup var naming, minor refactors (ToArra to avoid multiple enumerations) * remove misclick * Update AuditLogActionType * Apply editorconfig * Apply editorconfig * Fix Typos and use new() * nuke old auditLog abstraction, add new Auditlogentry types and start full rewrite of Guild#GetAuditLogsAsync * Make PropertyChange a struct and start to split the auditlogentry parsing into AuditLogParser * fix indentation * Continue moving * Continue moving * Continue moving * The great moving * Add new Event and rename the GuildBan intent to GuildModeration (according to the discord docs) * init Event... * Fix caches for ResponsibleUser * Use the guild cache * Update data representation * Update data representation * Fix Permission updates * Add check to minimize api calls * Re-added a flag that I had deleted + headers formatting. (#1587) * Added missing flag, and remove useless flag * Added headers to Formatter.cs * Re-added a flag that I had deleted. * System alert channel add (#1588) * SafetyAlertsChannel property added. * Handle nullable safety alerts channel ID. (#1597) * fix: Use `DiscordJson` to deserialize GDMs * fix indentation * why are you running * Add missing parser methods * Finish last parsing Method * Add missing docs and formatting * Update and use thread cache * Rename autogenerated parameter * Update PropertyChange * Adding xmldocs, revert Intent renaming, update method return types * ups * Add toggleable logging * Great moving the 2nd * Fix missing init * Fix wrong casting and rename member * add missing key on threads and integration * add missing key on automod entries --------- Co-authored-by: P A T R I C K <[email protected]> Co-authored-by: Livia Silvercrown <[email protected]> Co-authored-by: Velvet Toroyashi <[email protected]>
5 participants
Summary
I started to cleanup the GetAuditLogs method on DiscordGuild and updated the AuditLogActionType Enum
Notes
Feel free to give me feedback and point out additional methods i can cleanup in this scope. I thought about rewriting other auditlog related sections but i dont know entirely how it works
Tasks