Improve Metadata class #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a base metadata class that can be inherited from each service. This PR follows discussion from #109.
graph TD; nwis.NWIS_Metadata-->utils.BaseMetadata; wqp.WQP_Metadata-->utils.BaseMetadata;Changes in
dataretrieval.utils:BaseMetadataclass is implemented such that it is initialized from the a request (md = BaseMetadata(request)). However, each service should inherit fromBaseMetadataand implement their particular methods.set_metadatafunction is removed, this is handled by the BaseMetadata's methods.Changes in
dataretrieval.nwis:NWIS_Metadataclass inherits fromutils.BaseMetadata. It implementssite_infoandvariable_infoas properties and handles the metadata comments.__repr__of the Metadata object.Example:
Changes in
dataretrieval.wqp:utils.BaseMetadataand implementssite_infoproperty.Example:
Changes in
tests:Breaking changes:
md.site_infoandmd.variable_infoare no longer callables but class properties. I am not sure why those were implemented to return lambda functions, but my guess is so the service query was only made if they where explicitly called by the user. If that was the case, the@propertydecorator should take care of that.