[WIP] Llama implementation for GritLM#63
Open
minsik-ai wants to merge 4 commits intoContextualAI:mainfrom
Open
[WIP] Llama implementation for GritLM#63minsik-ai wants to merge 4 commits intoContextualAI:mainfrom
minsik-ai wants to merge 4 commits intoContextualAI:mainfrom
Conversation
Contributor
Author
Contributor
Author
|
Thanks for your work! Will test your script in my environment. |
ThisisXXZ
reviewed
Nov 16, 2024
| attention_mask, | ||
| (batch_size, seq_length), | ||
| input_tensor, | ||
| past_key_values_length, |
There was a problem hiding this comment.
local variable 'past_key_values_length' referenced before assignment in line 1149. I'm not quite familiar with the logic here, but it seems that past_key_values = 0 in line 1127 prevents the program from going into the conditional if past_key_values: in line 1128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress! Not tested yet.
is_causalsupport added.Uploading for comments.