Skip to content

Conversation

@ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

The commit refactored the unit test, we introduced Moq and static code analysis.

@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #255 into master will decrease coverage by 9.92%.
The diff coverage is 97.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   97.36%   87.44%   -9.93%     
==========================================
  Files          35       36       +1     
  Lines        2469     2477       +8     
==========================================
- Hits         2404     2166     -238     
- Misses         65      311     +246
Impacted Files Coverage Δ
src/CatLib.Core/Support/Arr.cs 97.48% <100%> (-0.84%) ⬇️
src/CatLib.Core/Container/Bindable.cs 96.22% <100%> (-1.89%) ⬇️
src/CatLib.Core/Support/Guard.cs 82.92% <100%> (+0.42%) ⬆️
src/CatLib.Core/Container/GivenData.cs 100% <100%> (ø) ⬆️
src/CatLib.Core/Container/MethodContainer.cs 92.3% <100%> (-7.7%) ⬇️
src/CatLib.Core/Container/ExtendContainer.cs 69.39% <100%> (-30.61%) ⬇️
src/CatLib.Core/CatLib/Application.cs 98.07% <100%> (-0.97%) ⬇️
src/CatLib.Core/Container/InjectAttribute.cs 100% <100%> (ø)
src/CatLib.Core/Container/BindData.cs 95% <100%> (-5%) ⬇️
src/CatLib.Core/Container/Container.cs 96.33% <95.83%> (-3.35%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e8058...3d1c7b6. Read the comment docs.

@ymh199478 ymh199478 mentioned this pull request Jul 20, 2019
55 tasks
@ymh199478 ymh199478 merged commit 6f19ab9 into master Jul 20, 2019
@ymh199478 ymh199478 changed the title Refactoring unit test Refactoring unit test and add Inject required support Jul 20, 2019
@ymh199478 ymh199478 deleted the changed/free-refactoring-unit-test branch July 23, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants