Skip to content

Conversation

@ymh199478
Copy link
Contributor

Q A
Branch? v2.0(master)
Bug fix? No
New feature? No
Deprecations? No
Internal Changed? Yes
Removed No
Tests pass? Yes
Doc pr? No

Migrate projects to .net standard 2.0.

@ymh199478
Copy link
Contributor Author

Unit tests fail, and need to wait for the event system related fixes before they can be merged.

@ymh199478
Copy link
Contributor Author

CI needs adjustment support

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@747fee3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #225   +/-   ##
=========================================
  Coverage          ?   96.04%           
=========================================
  Files             ?       33           
  Lines             ?     2857           
  Branches          ?        0           
=========================================
  Hits              ?     2744           
  Misses            ?      113           
  Partials          ?        0
Impacted Files Coverage Δ
src/CatLib.Core/Support/SystemTime.cs 100% <ø> (ø)
src/CatLib.Core/Support/Extension/IntExtension.cs 100% <ø> (ø)
src/CatLib.Core/CatLib/Application.cs 99.3% <ø> (ø)
...c/CatLib.Core/Support/Extension/StreamExtension.cs 91.89% <ø> (ø)
src/CatLib.Core/Support/Arr.cs 98.72% <ø> (ø)
src/CatLib.Core/Support/Str.cs 99.46% <ø> (ø)
src/CatLib.Core/Support/Util.cs 100% <ø> (ø)
...c/CatLib.Core/Support/Extension/StringExtension.cs 100% <ø> (ø)
src/CatLib.Core/Support/Stream/StorageStream.cs 92.75% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747fee3...f4c0b35. Read the comment docs.

@ymh199478
Copy link
Contributor Author

Commit removed some unit tests that will be deleted classes to pass the test.
These classes that will be removed will be deleted in subsequent pull request.

@ymh199478 ymh199478 merged commit 2613716 into master May 18, 2019
@ymh199478 ymh199478 mentioned this pull request May 18, 2019
55 tasks
@ymh199478 ymh199478 deleted the changed/free-netstandard branch May 18, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants