Handle Rspec negated be_able_to for actions list#807
Closed
uxxman wants to merge 1 commit intoCanCanCommunity:developfrom
uxxman:patch-1
Closed
Handle Rspec negated be_able_to for actions list#807uxxman wants to merge 1 commit intoCanCanCommunity:developfrom uxxman:patch-1
uxxman wants to merge 1 commit intoCanCanCommunity:developfrom
uxxman:patch-1
Conversation
Member
|
We are planning to disable negate able_to matcher for multiple actions. This lead to a lot of confusion in the past. See #796 |
Author
|
@coorasse thanks for the update. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the rspec matcher handles list of actions correctly for
to be_able_tocase and returns successfully when the user is allowed to perform all the specified actions.But, it doesn't work correctly for a list of actions for the negated cases.
The underlying issue is this line
It will return false when we have some true values and even one false value.
PR fixes the issue by making use of => https://relishapp.com/rspec/rspec-expectations/docs/custom-matchers/define-a-custom-matcher#matcher-with-separate-logic-for-expect().to-and-expect().not-to