updated deploy.sh

HariSekhon · HariSekhon · commit 6faf71397bc1 · 2020-10-16T17:34:32.000+01:00
diff --git a/gcp_cloud_function_sql_export/deploy.sh b/gcp_cloud_function_sql_export/deploy.sh
@@ -4,6 +4,14 @@
 #  Author: Hari Sekhon
 #  Date: 2020-10-16 10:12:26 +0100 (Fri, 16 Oct 2020)
 #
+#  https://github.com/HariSekhon/pytools
+#
+#  License: see accompanying Hari Sekhon LICENSE file
+#
+#  If you're using my code you're welcome to connect with me on LinkedIn and optionally send me feedback to help steer this or other code I publish
+#
+#  https://www.linkedin.com/in/HariSekhon
+#
 
 set -euo pipefail
 [ -n "${DEBUG:-}" ] && set -x
@@ -17,6 +25,9 @@ region="europe-west3"  # not available in all regions yet
 name="cloud-sql-backups"
 topic="cloud-sql-backups"
 service_account="cloud-function-sql-backup@$project.iam.gserviceaccount.com"
-vpc_connector="cloud-sql-backups"  # for triggering across regions since Cloud Function may not be in the same region as the Cloud SQL instances to back up
+# https://console.cloud.google.com/marketplace/product/google/vpcaccess.googleapis.com
+# for serverless VPC access to resources using their Private IPs
+# since we're only accessing the SQL Admin API we don't need this
+#vpc_connector="cloud-sql-backups"
 
-gcloud functions deploy "$name" --trigger-topic "$topic" --runtime python37 --entry-point main --service-account "$service_account" --region "$region" --timeout 60 --vpc-connector "$vpc_connector" --memory 128MB
+gcloud functions deploy "$name" --trigger-topic "$topic" --runtime python37 --entry-point main --service-account "$service_account" --region "$region" --timeout 60 --memory 128MB # --vpc-connector "$vpc_connector"
