Open
Conversation
Member
|
Are all those changes on the embedded webUi files (html, js and css) needed? |
Contributor
Author
|
They add a user-facing note that the Web UI will stop after the WiFi attack configuration finishes, and they also adjust the command sequence so execution waits for user confirmation before sending commands. This ensures AP mode shuts down cleanly before starting the WiFi feature, avoiding conflicts or crashes. So ig the Web UI changes are needed, but if you want I can adjust them as you prefer and remove some changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request fixes a crash/failure in the Web UI when launching WiFi features while the device is running in AP mode.
WiFi features are now deferred until the user completes configuration and explicitly confirms execution. Upon confirmation, the Web UI/AP mode is cleanly stopped and the selected WiFi feature is started, avoiding simultaneous WiFi mode conflicts.
This is a minimal sequencing fix and does not redesign the Web UI or WiFi features.
Types of Changes
Bugfix – prevents Web UI WiFi features from crashing due to AP/WiFi mode conflicts
Behavior improvement – defers execution until user confirmation
Verification
Start the device and open the Web UI in AP mode
Navigate to a WiFi feature (Evil Portal, Deauth Flood, target attacks, etc.)
Complete the configuration steps in the Web UI
Confirm execution
Verify that:
The Web UI/AP mode shuts down cleanly
The selected WiFi feature starts successfully
No crash or WiFi conflict occurs
Testing
Linked Issues
User-Facing Change
Further Comments