fixes the cache plugin #1013
Merged
fixes the cache plugin #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves a couple of long-standing issues with the cache plugin and provides a more efficient procedure for finding the cache index (see BinaryAnalysisPlatform#966) and prevents the leakage of entries in the case when the same entry is added twice (see BinaryAnalysisPlatform#967).
ivg
requested changes
Nov 11, 2019
plugins/cache/cache_main.ml
Outdated
| }) in | ||
| let entry = { | ||
| size = size path; path; atime = ctime; ctime; hits = 1 | ||
| } in |
Member
There was a problem hiding this comment.
I don't like performing a removal as a side-effect of a pure function. It is better to express it explicitly, e.g.,
if Map.mem index.entries id then begin
warning "overwriting an entry";
Index.remove_entry e;
endAlso, in general, this PR doesn't follow the spirit of the implementation, where the entries are removed all in one place. This is assumed in the code so I'm not sure whether this change breaks this assumptions anywhere.
ivg
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a couple of long-standing issues with the cache plugin
and provides a more efficient procedure for finding the cache index
(see #966) and prevents the leakage of entries in the case when the same
entry is added twice (see #967).