fix and cleanup get-transaction-list; add back to sample code tests

adavidw · adavidw · commit 27cbe9e2dbca · 2017-10-23T16:00:47.000-06:00
diff --git a/TransactionReporting/get-transaction-list.rb b/TransactionReporting/get-transaction-list.rb
@@ -10,8 +10,7 @@ def get_transaction_List()
   
     transaction1 = AuthorizeNet::API::Transaction.new(config['api_login_id'], config['api_transaction_key'], :gateway => :sandbox)
   
-    batchId = "4606008"
-    #batchId = "4551107"
+    batchId = "7590305"
     request = AuthorizeNet::API::GetTransactionListRequest.new
     request.batchId = batchId
     request.paging = Paging.new;
@@ -20,28 +19,35 @@ def get_transaction_List()
     request.paging.offset = 1;
 
     request.sorting = TransactionListSorting.new;
-    request.sorting.orderBy = TransactionListOrderFieldEnum.Id;
+    request.sorting.orderBy = TransactionListOrderFieldEnum::Id;
     request.sorting.orderDescending = true;
 
     response = transaction1.get_transaction_list(request)
-    
-    if response.messages.resultCode == MessageTypeEnum::Ok
-    	transactions = response.transactions
-    	if transactions == nil
-    		puts "#{response.messages.messages[0].text}"
-    	else
-        response.transactions.transaction.each do |trans|
-  	  		puts "\nTransaction ID :  #{trans.transId} "
-  	  		puts "Submitted on (Local) :  %s " %[trans.submitTimeUTC]
-  	  		puts "Status :  #{trans.transactionStatus} "
-  	  		puts "Settle Amount :  %.2f " %[trans.settleAmount]
-  	  	end
-    	end
+
+    if response != nil
+      if response.messages.resultCode == MessageTypeEnum::Ok
+        if response.transactions == nil
+          puts "#{response.messages.messages[0].text}"
+        else
+          puts "Successfully got the list of transactions for batch " + batchId + "."          
+          response.transactions.transaction.each do |trans|
+            puts "Transaction ID: #{trans.transId} "
+            puts "  Submitted on (Local): %s " % [trans.submitTimeUTC]
+            puts "  Status: #{trans.transactionStatus} "
+            puts "  Settle Amount: %.2f " % [trans.settleAmount]
+          end
+        end
+      else
+        puts "Error: Failed to get Transaction List."
+        puts "Error Text: #{response.messages.messages[0].text}"
+        puts "Error Code: #{response.messages.messages[0].code}"
+      end
     else
-    	puts "Error: Failed to get Transaction List\n"
-    	puts "Error Text :  #{response.messages.messages[0].text} \n"
-    	puts "Error Code :  #{response.messages.messages[0].code} "
+      puts "Error: Failed to get Transaction List."
+      puts "Error Text: #{response.messages.messages[0].text}"
+      puts "Error Code: #{response.messages.messages[0].code}"
     end
+
     return response
   
   end
diff --git a/spec/sample_code_spec.rb b/spec/sample_code_spec.rb
@@ -246,7 +246,7 @@ def validate_response(response= nil)
     response = get_transaction_Details()
     validate_response(response)
     
-    #response = get_transaction_List()
+    response = get_transaction_List()
     validate_response(response)
     
     response = get_unsettled_transaction_List()
