Skip to content

disable speaker labels by default#102

Merged
m-ods merged 1 commit into
mainfrom
speakerlabelsfix
Jul 6, 2023
Merged

disable speaker labels by default#102
m-ods merged 1 commit into
mainfrom
speakerlabelsfix

Conversation

@m-ods

@m-ods m-ods commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Why

Please include the tickets/requirements that are being addressed

Using the CLI with multi-lang doesn't work because speaker labels are enabled by default. We also don't have clear documentation for disabling speaker labels and hence my proposed change will disable speaker labels by default.

## What is changing
Please describe what is being changed
Resetting Speaker Labels to be false by default.

How to test

Please comment the steps required to reproduce the changes
Transcribe a file in another language with the CLI. For e.g.:
"assemblyai transcribe "https://www.youtube.com/watch?v=TJxDnHVX7mE" -g "es"
Expected behaviour: file is transcribed in Spanish
Current behaviour: error- speaker labels are not supported in Spanish

@m-ods m-ods requested a review from fcastillo90 July 6, 2023 02:13

@fcastillo90 fcastillo90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-ods m-ods merged commit a37341c into main Jul 6, 2023
@m-ods m-ods deleted the speakerlabelsfix branch July 6, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants