Fix null handling in MethodCall parameter execution#3584
Fix null handling in MethodCall parameter execution#3584lvca merged 1 commit intoArcadeData:mainfrom
Conversation
…T clauses When executing SQL queries with LET variables containing UNIONALL and string method calls (e.g., .replace()), $current can be null while targetObjects is a non-Identifiable/non-Result value. Added an else-if branch to handle null val by passing null Identifiable to Expression.execute(), preventing the CommandExecutionException. https://claude.ai/code/session_019HJhUeYmAHEL2wx5monhz9
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of SQL query execution by addressing a critical null pointer handling issue within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Great, thanks! Merging it now. |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a null pointer issue in MethodCall.execute() by adding a check for a null $current variable. The change is minimal and effective. A new test case is added to cover the failing scenario, which is great. I've suggested a small improvement to the test query to enhance its readability and maintainability by reducing code duplication.
| "SELECT expand($c) LET " | ||
| + "$a = (SELECT identity, @rid as id FROM NER " | ||
| + "WHERE identity.replace('\\n', ' ').replace('\\t', ' ').replace(' ', ' ') ILIKE ('%' + :keyWordIdentifier_0 + '%') " | ||
| + "AND identity.replace('\\n', ' ').replace('\\t', ' ').replace(' ', ' ') ILIKE ('%' + :keyWordIdentifier_1 + '%')), " | ||
| + "$b = (SELECT identity, @rid as id FROM THEME " | ||
| + "WHERE identity.replace('\\n', ' ').replace('\\t', ' ').replace(' ', ' ') ILIKE ('%' + :keyWordIdentifier_0 + '%') " | ||
| + "AND identity.replace('\\n', ' ').replace('\\t', ' ').replace(' ', ' ') ILIKE ('%' + :keyWordIdentifier_1 + '%')), " | ||
| + "$c = UNIONALL($a, $b)", |
There was a problem hiding this comment.
The SQL query in this test has a significant amount of duplicated code. The expression identity.replace('\n', ' ').replace('\t', ' ').replace(' ', ' ') is repeated four times. To improve readability and maintainability, you can use a LET clause within the subqueries to define this expression as a variable.
"SELECT expand($c) LET "
+ "$a = (SELECT identity, @rid as id FROM NER "
+ " LET $clean_identity = identity.replace('\\n', ' ').replace('\\t', ' ').replace(' ', ' ') "
+ " WHERE $clean_identity ILIKE ('%' + :keyWordIdentifier_0 + '%') "
+ " AND $clean_identity ILIKE ('%' + :keyWordIdentifier_1 + '%')), "
+ "$b = (SELECT identity, @rid as id FROM THEME "
+ " LET $clean_identity = identity.replace('\\n', ' ').replace('\\t', ' ').replace(' ', ' ') "
+ " WHERE $clean_identity ILIKE ('%' + :keyWordIdentifier_0 + '%') "
+ " AND $clean_identity ILIKE ('%' + :keyWordIdentifier_1 + '%')), "
+ "$c = UNIONALL($a, $b)",
🧪 CI InsightsHere's what we observed from your CI run for 185c73d. 🟢 All jobs passed!But CI Insights is watching 👀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3584 +/- ##
==========================================
+ Coverage 65.02% 65.65% +0.63%
==========================================
Files 1514 1514
Lines 103659 103660 +1
Branches 21454 21454
==========================================
+ Hits 67403 68058 +655
+ Misses 27075 26362 -713
- Partials 9181 9240 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps the github-actions group with 5 updates: | Package | From | To | | --- | --- | --- | | [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) | `1.0.72` | `1.0.76` | | [github/codeql-action](https://github.com/github/codeql-action) | `4.32.6` | `4.34.1` | | [zgosalvez/github-actions-ensure-sha-pinned-actions](https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions) | `5.0.2` | `5.0.3` | | [actions/cache](https://github.com/actions/cache) | `5.0.3` | `5.0.4` | | [codecov/codecov-action](https://github.com/codecov/codecov-action) | `5.5.2` | `5.5.3` | Updates `anthropics/claude-code-action` from 1.0.72 to 1.0.76 Release notes *Sourced from [anthropics/claude-code-action's releases](https://github.com/anthropics/claude-code-action/releases).* > v1.0.76 > ------- > > **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.76> > > v1.0.75 > ------- > > **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.75> > > v1.0.74 > ------- > > What's Changed > -------------- > > * Restore .claude/ and .mcp.json from PR base branch before CLI runs by [`@km-anthropic`](https://github.com/km-anthropic) in [anthropics/claude-code-action#1066](https://redirect.github.com/anthropics/claude-code-action/pull/1066) > * Remove redundant git status/diff/log from tag mode allowlist by [`@ddworken`](https://github.com/ddworken) in [anthropics/claude-code-action#1075](https://redirect.github.com/anthropics/claude-code-action/pull/1075) > > **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.74> > > v1.0.73 > ------- > > **Full Changelog**: <anthropics/claude-code-action@v1...v1.0.73> Commits * [`6062f37`](anthropics/claude-code-action@6062f37) chore: bump Claude Code to 2.1.81 and Agent SDK to 0.2.81 * [`df37d2f`](anthropics/claude-code-action@df37d2f) chore: bump Claude Code to 2.1.79 and Agent SDK to 0.2.79 * [`1ba15be`](anthropics/claude-code-action@1ba15be) Remove redundant git status/diff/log from tag mode allowlist ([#1075](https://redirect.github.com/anthropics/claude-code-action/issues/1075)) * [`9ddce40`](anthropics/claude-code-action@9ddce40) Restore .claude/ and .mcp.json from PR base branch before CLI runs ([#1066](https://redirect.github.com/anthropics/claude-code-action/issues/1066)) * [`1b422b3`](anthropics/claude-code-action@1b422b3) chore: bump Claude Code to 2.1.78 and Agent SDK to 0.2.77 * [`4c044bb`](anthropics/claude-code-action@4c044bb) chore: bump Claude Code to 2.1.77 and Agent SDK to 0.2.77 * See full diff in [compare view](anthropics/claude-code-action@cd77b50...6062f37) Updates `github/codeql-action` from 4.32.6 to 4.34.1 Release notes *Sourced from [github/codeql-action's releases](https://github.com/github/codeql-action/releases).* > v4.34.1 > ------- > > * Downgrade default CodeQL bundle version to [2.24.3](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.24.3) due to issues with a small percentage of Actions and JavaScript analyses. [#3762](https://redirect.github.com/github/codeql-action/pull/3762) > > v4.34.0 > ------- > > * Added an experimental change which disables TRAP caching when [improved incremental analysis](https://redirect.github.com/github/roadmap/issues/1158) is enabled, since improved incremental analysis supersedes TRAP caching. This will improve performance and reduce Actions cache usage. We expect to roll this change out to everyone in March. [#3569](https://redirect.github.com/github/codeql-action/pull/3569) > * We are rolling out improved incremental analysis to C/C++ analyses that use build mode `none`. We expect this rollout to be complete by the end of April 2026. [#3584](https://redirect.github.com/github/codeql-action/pull/3584) > * Update default CodeQL bundle version to [2.25.0](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.0). [#3585](https://redirect.github.com/github/codeql-action/pull/3585) > > v4.33.0 > ------- > > * Upcoming change: Starting April 2026, the CodeQL Action will skip collecting file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses. Pull request analyses will log a warning about this upcoming change. [#3562](https://redirect.github.com/github/codeql-action/pull/3562) > > To opt out of this change: > > + **Repositories owned by an organization:** Create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings. For more information, see [Managing custom properties for repositories in your organization](https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization). Alternatively, if you are using an advanced setup workflow, you can set the `CODEQL_ACTION_FILE_COVERAGE_ON_PRS` environment variable to `true` in your workflow. > + **User-owned repositories using default setup:** Switch to an advanced setup workflow and set the `CODEQL_ACTION_FILE_COVERAGE_ON_PRS` environment variable to `true` in your workflow. > + **User-owned repositories using advanced setup:** Set the `CODEQL_ACTION_FILE_COVERAGE_ON_PRS` environment variable to `true` in your workflow. > * Fixed [a bug](https://redirect.github.com/github/codeql-action/issues/3555) which caused the CodeQL Action to fail loading repository properties if a "Multi select" repository property was configured for the repository. [#3557](https://redirect.github.com/github/codeql-action/pull/3557) > * The CodeQL Action now loads [custom repository properties](https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization) on GitHub Enterprise Server, enabling the customization of features such as `github-codeql-disable-overlay` that was previously only available on GitHub.com. [#3559](https://redirect.github.com/github/codeql-action/pull/3559) > * Once [private package registries](https://docs.github.com/en/code-security/how-tos/secure-at-scale/configure-organization-security/manage-usage-and-access/giving-org-access-private-registries) can be configured with OIDC-based authentication for organizations, the CodeQL Action will now be able to accept such configurations. [#3563](https://redirect.github.com/github/codeql-action/pull/3563) > * Fixed the retry mechanism for database uploads. Previously this would fail with the error "Response body object should not be disturbed or locked". [#3564](https://redirect.github.com/github/codeql-action/pull/3564) > * A warning is now emitted if the CodeQL Action detects a repository property whose name suggests that it relates to the CodeQL Action, but which is not one of the properties recognised by the current version of the CodeQL Action. [#3570](https://redirect.github.com/github/codeql-action/pull/3570) Changelog *Sourced from [github/codeql-action's changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md).* > CodeQL Action Changelog > ======================= > > See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. > > [UNRELEASED] > ------------ > > No user facing changes. > > 4.34.1 - 20 Mar 2026 > -------------------- > > * Downgrade default CodeQL bundle version to [2.24.3](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.24.3) due to issues with a small percentage of Actions and JavaScript analyses. [#3762](https://redirect.github.com/github/codeql-action/pull/3762) > > 4.34.0 - 20 Mar 2026 > -------------------- > > * Added an experimental change which disables TRAP caching when [improved incremental analysis](https://redirect.github.com/github/roadmap/issues/1158) is enabled, since improved incremental analysis supersedes TRAP caching. This will improve performance and reduce Actions cache usage. We expect to roll this change out to everyone in March. [#3569](https://redirect.github.com/github/codeql-action/pull/3569) > * We are rolling out improved incremental analysis to C/C++ analyses that use build mode `none`. We expect this rollout to be complete by the end of April 2026. [#3584](https://redirect.github.com/github/codeql-action/pull/3584) > * Update default CodeQL bundle version to [2.25.0](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.25.0). [#3585](https://redirect.github.com/github/codeql-action/pull/3585) > > 4.33.0 - 16 Mar 2026 > -------------------- > > * Upcoming change: Starting April 2026, the CodeQL Action will skip collecting file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses. Pull request analyses will log a warning about this upcoming change. [#3562](https://redirect.github.com/github/codeql-action/pull/3562) > > To opt out of this change: > > + **Repositories owned by an organization:** Create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings. For more information, see [Managing custom properties for repositories in your organization](https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization). Alternatively, if you are using an advanced setup workflow, you can set the `CODEQL_ACTION_FILE_COVERAGE_ON_PRS` environment variable to `true` in your workflow. > + **User-owned repositories using default setup:** Switch to an advanced setup workflow and set the `CODEQL_ACTION_FILE_COVERAGE_ON_PRS` environment variable to `true` in your workflow. > + **User-owned repositories using advanced setup:** Set the `CODEQL_ACTION_FILE_COVERAGE_ON_PRS` environment variable to `true` in your workflow. > * Fixed [a bug](https://redirect.github.com/github/codeql-action/issues/3555) which caused the CodeQL Action to fail loading repository properties if a "Multi select" repository property was configured for the repository. [#3557](https://redirect.github.com/github/codeql-action/pull/3557) > * The CodeQL Action now loads [custom repository properties](https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization) on GitHub Enterprise Server, enabling the customization of features such as `github-codeql-disable-overlay` that was previously only available on GitHub.com. [#3559](https://redirect.github.com/github/codeql-action/pull/3559) > * Once [private package registries](https://docs.github.com/en/code-security/how-tos/secure-at-scale/configure-organization-security/manage-usage-and-access/giving-org-access-private-registries) can be configured with OIDC-based authentication for organizations, the CodeQL Action will now be able to accept such configurations. [#3563](https://redirect.github.com/github/codeql-action/pull/3563) > * Fixed the retry mechanism for database uploads. Previously this would fail with the error "Response body object should not be disturbed or locked". [#3564](https://redirect.github.com/github/codeql-action/pull/3564) > * A warning is now emitted if the CodeQL Action detects a repository property whose name suggests that it relates to the CodeQL Action, but which is not one of the properties recognised by the current version of the CodeQL Action. [#3570](https://redirect.github.com/github/codeql-action/pull/3570) > > 4.32.6 - 05 Mar 2026 > -------------------- > > * Update default CodeQL bundle version to [2.24.3](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.24.3). [#3548](https://redirect.github.com/github/codeql-action/pull/3548) > > 4.32.5 - 02 Mar 2026 > -------------------- > > * Repositories owned by an organization can now set up the `github-codeql-disable-overlay` custom repository property to disable [improved incremental analysis for CodeQL](https://redirect.github.com/github/roadmap/issues/1158). First, create a custom repository property with the name `github-codeql-disable-overlay` and the type "True/false" in the organization's settings. Then in the repository's settings, set this property to `true` to disable improved incremental analysis. For more information, see [Managing custom properties for repositories in your organization](https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization). This feature is not yet available on GitHub Enterprise Server. [#3507](https://redirect.github.com/github/codeql-action/pull/3507) > * Added an experimental change so that when [improved incremental analysis](https://redirect.github.com/github/roadmap/issues/1158) fails on a runner — potentially due to insufficient disk space — the failure is recorded in the Actions cache so that subsequent runs will automatically skip improved incremental analysis until something changes (e.g. a larger runner is provisioned or a new CodeQL version is released). We expect to roll this change out to everyone in March. [#3487](https://redirect.github.com/github/codeql-action/pull/3487) > * The minimum memory check for improved incremental analysis is now skipped for CodeQL 2.24.3 and later, which has reduced peak RAM usage. [#3515](https://redirect.github.com/github/codeql-action/pull/3515) > * Reduced log levels for best-effort private package registry connection check failures to reduce noise from workflow annotations. [#3516](https://redirect.github.com/github/codeql-action/pull/3516) > * Added an experimental change which lowers the minimum disk space requirement for [improved incremental analysis](https://redirect.github.com/github/roadmap/issues/1158), enabling it to run on standard GitHub Actions runners. We expect to roll this change out to everyone in March. [#3498](https://redirect.github.com/github/codeql-action/pull/3498) > * Added an experimental change which allows the `start-proxy` action to resolve the CodeQL CLI version from feature flags instead of using the linked CLI bundle version. We expect to roll this change out to everyone in March. [#3512](https://redirect.github.com/github/codeql-action/pull/3512) > * The previously experimental changes from versions 4.32.3, 4.32.4, 3.32.3 and 3.32.4 are now enabled by default. [#3503](https://redirect.github.com/github/codeql-action/pull/3503), [#3504](https://redirect.github.com/github/codeql-action/pull/3504) > > 4.32.4 - 20 Feb 2026 > -------------------- > > * Update default CodeQL bundle version to [2.24.2](https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.24.2). [#3493](https://redirect.github.com/github/codeql-action/pull/3493) > * Added an experimental change which improves how certificates are generated for the authentication proxy that is used by the CodeQL Action in Default Setup when [private package registries are configured](https://docs.github.com/en/code-security/how-tos/secure-at-scale/configure-organization-security/manage-usage-and-access/giving-org-access-private-registries). This is expected to generate more widely compatible certificates and should have no impact on analyses which are working correctly already. We expect to roll this change out to everyone in February. [#3473](https://redirect.github.com/github/codeql-action/pull/3473) ... (truncated) Commits * [`3869755`](github/codeql-action@3869755) Merge pull request [#3763](https://redirect.github.com/github/codeql-action/issues/3763) from github/update-v4.34.1-095e0fe50 * [`20e68ac`](github/codeql-action@20e68ac) Update changelog for v4.34.1 * [`095e0fe`](github/codeql-action@095e0fe) Merge pull request [#3762](https://redirect.github.com/github/codeql-action/issues/3762) from github/henrymercer/downgrade-default-bundle * [`47b94fe`](github/codeql-action@47b94fe) Add changelog note * [`51a1d69`](github/codeql-action@51a1d69) Downgrade default bundle to codeql-bundle-v2.24.3 * [`510cf73`](github/codeql-action@510cf73) Merge pull request [#3589](https://redirect.github.com/github/codeql-action/issues/3589) from github/mergeback/v4.34.0-to-main-c6f93110 * [`89f0c86`](github/codeql-action@89f0c86) Rebuild * [`c3f90ba`](github/codeql-action@c3f90ba) Update changelog and version after v4.34.0 * [`c6f9311`](github/codeql-action@c6f9311) Merge pull request [#3588](https://redirect.github.com/github/codeql-action/issues/3588) from github/update-v4.34.0-30c555a52 * [`eeb9b3f`](github/codeql-action@eeb9b3f) Update changelog for v4.34.0 * Additional commits viewable in [compare view](github/codeql-action@0d579ff...3869755) Updates `zgosalvez/github-actions-ensure-sha-pinned-actions` from 5.0.2 to 5.0.3 Release notes *Sourced from [zgosalvez/github-actions-ensure-sha-pinned-actions's releases](https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions/releases).* > v5.0.3 > ------ > > What's Changed > -------------- > > * Bump flatted from 3.3.1 to 3.4.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [zgosalvez/github-actions-ensure-sha-pinned-actions#299](https://redirect.github.com/zgosalvez/github-actions-ensure-sha-pinned-actions/pull/299) > > **Full Changelog**: <zgosalvez/github-actions-ensure-sha-pinned-actions@v5...v5.0.3> Commits * [`471d5ac`](zgosalvez/github-actions-ensure-sha-pinned-actions@471d5ac) Bump flatted from 3.3.1 to 3.4.2 ([#299](https://redirect.github.com/zgosalvez/github-actions-ensure-sha-pinned-actions/issues/299)) * See full diff in [compare view](zgosalvez/github-actions-ensure-sha-pinned-actions@cc9ffdc...471d5ac) Updates `actions/cache` from 5.0.3 to 5.0.4 Release notes *Sourced from [actions/cache's releases](https://github.com/actions/cache/releases).* > v5.0.4 > ------ > > What's Changed > -------------- > > * Add release instructions and update maintainer docs by [`@Link`](https://github.com/Link)- in [actions/cache#1696](https://redirect.github.com/actions/cache/pull/1696) > * Potential fix for code scanning alert no. 52: Workflow does not contain permissions by [`@Link`](https://github.com/Link)- in [actions/cache#1697](https://redirect.github.com/actions/cache/pull/1697) > * Fix workflow permissions and cleanup workflow names / formatting by [`@Link`](https://github.com/Link)- in [actions/cache#1699](https://redirect.github.com/actions/cache/pull/1699) > * docs: Update examples to use the latest version by [`@XZTDean`](https://github.com/XZTDean) in [actions/cache#1690](https://redirect.github.com/actions/cache/pull/1690) > * Fix proxy integration tests by [`@Link`](https://github.com/Link)- in [actions/cache#1701](https://redirect.github.com/actions/cache/pull/1701) > * Fix cache key in examples.md for bun.lock by [`@RyPeck`](https://github.com/RyPeck) in [actions/cache#1722](https://redirect.github.com/actions/cache/pull/1722) > * Update dependencies & patch security vulnerabilities by [`@Link`](https://github.com/Link)- in [actions/cache#1738](https://redirect.github.com/actions/cache/pull/1738) > > New Contributors > ---------------- > > * [`@XZTDean`](https://github.com/XZTDean) made their first contribution in [actions/cache#1690](https://redirect.github.com/actions/cache/pull/1690) > * [`@RyPeck`](https://github.com/RyPeck) made their first contribution in [actions/cache#1722](https://redirect.github.com/actions/cache/pull/1722) > > **Full Changelog**: <actions/cache@v5...v5.0.4> Changelog *Sourced from [actions/cache's changelog](https://github.com/actions/cache/blob/main/RELEASES.md).* > Releases > ======== > > How to prepare a release > ------------------------ > > > [!NOTE] > > Relevant for maintainers with write access only. > > 1. Switch to a new branch from `main`. > 2. Run `npm test` to ensure all tests are passing. > 3. Update the version in [`https://github.com/actions/cache/blob/main/package.json`](https://github.com/actions/cache/blob/main/package.json). > 4. Run `npm run build` to update the compiled files. > 5. Update this [`https://github.com/actions/cache/blob/main/RELEASES.md`](https://github.com/actions/cache/blob/main/RELEASES.md) with the new version and changes in the `## Changelog` section. > 6. Run `licensed cache` to update the license report. > 7. Run `licensed status` and resolve any warnings by updating the [`https://github.com/actions/cache/blob/main/.licensed.yml`](https://github.com/actions/cache/blob/main/.licensed.yml) file with the exceptions. > 8. Commit your changes and push your branch upstream. > 9. Open a pull request against `main` and get it reviewed and merged. > 10. Draft a new release <https://github.com/actions/cache/releases> use the same version number used in `package.json` > 1. Create a new tag with the version number. > 2. Auto generate release notes and update them to match the changes you made in `RELEASES.md`. > 3. Toggle the set as the latest release option. > 4. Publish the release. > 11. Navigate to <https://github.com/actions/cache/actions/workflows/release-new-action-version.yml> > 1. There should be a workflow run queued with the same version number. > 2. Approve the run to publish the new version and update the major tags for this action. > > Changelog > --------- > > ### 5.0.4 > > * Bump `minimatch` to v3.1.5 (fixes ReDoS via globstar patterns) > * Bump `undici` to v6.24.1 (WebSocket decompression bomb protection, header validation fixes) > * Bump `fast-xml-parser` to v5.5.6 > > ### 5.0.3 > > * Bump `@actions/cache` to v5.0.5 (Resolves: <https://github.com/actions/cache/security/dependabot/33>) > * Bump `@actions/core` to v2.0.3 > > ### 5.0.2 > > * Bump `@actions/cache` to v5.0.3 [#1692](https://redirect.github.com/actions/cache/pull/1692) > > ### 5.0.1 > > * Update `@azure/storage-blob` to `^12.29.1` via `@actions/[email protected]` [#1685](https://redirect.github.com/actions/cache/pull/1685) > > ### 5.0.0 > > > [!IMPORTANT] > > `actions/cache@v5` runs on the Node.js 24 runtime and requires a minimum Actions Runner version of `2.327.1`. ... (truncated) Commits * [`6682284`](actions/cache@6682284) Merge pull request [#1738](https://redirect.github.com/actions/cache/issues/1738) from actions/prepare-v5.0.4 * [`e340396`](actions/cache@e340396) Update RELEASES * [`8a67110`](actions/cache@8a67110) Add licenses * [`1865903`](actions/cache@1865903) Update dependencies & patch security vulnerabilities * [`5656298`](actions/cache@5656298) Merge pull request [#1722](https://redirect.github.com/actions/cache/issues/1722) from RyPeck/patch-1 * [`4e380d1`](actions/cache@4e380d1) Fix cache key in examples.md for bun.lock * [`b7e8d49`](actions/cache@b7e8d49) Merge pull request [#1701](https://redirect.github.com/actions/cache/issues/1701) from actions/Link-/fix-proxy-integration-tests * [`984a21b`](actions/cache@984a21b) Add traffic sanity check step * [`acf2f1f`](actions/cache@acf2f1f) Fix resolution * [`95a07c5`](actions/cache@95a07c5) Add wait for proxy * Additional commits viewable in [compare view](actions/cache@cdf6c1f...6682284) Updates `codecov/codecov-action` from 5.5.2 to 5.5.3 Release notes *Sourced from [codecov/codecov-action's releases](https://github.com/codecov/codecov-action/releases).* > v5.5.3 > ------ > > What's Changed > -------------- > > * build(deps): bump actions/github-script from 7.0.1 to 8.0.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [codecov/codecov-action#1874](https://redirect.github.com/codecov/codecov-action/pull/1874) > * chore(release): bump to 5.5.3 by [`@thomasrockhu-codecov`](https://github.com/thomasrockhu-codecov) in [codecov/codecov-action#1922](https://redirect.github.com/codecov/codecov-action/pull/1922) > > **Full Changelog**: <codecov/codecov-action@v5.5.2...v5.5.3> Changelog *Sourced from [codecov/codecov-action's changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md).* > v5.5.2 > ------ > > ### What's Changed > > **Full Changelog**: <https://github.com/codecov/codecov-action/compare/v5.5.1..v5.5.2> > > v5.5.1 > ------ > > ### What's Changed > > * fix: overwrite pr number on fork by [`@thomasrockhu-codecov`](https://github.com/thomasrockhu-codecov) in [codecov/codecov-action#1871](https://redirect.github.com/codecov/codecov-action/pull/1871) > * build(deps): bump actions/checkout from 4.2.2 to 5.0.0 by `@app/dependabot` in [codecov/codecov-action#1868](https://redirect.github.com/codecov/codecov-action/pull/1868) > * build(deps): bump github/codeql-action from 3.29.9 to 3.29.11 by `@app/dependabot` in [codecov/codecov-action#1867](https://redirect.github.com/codecov/codecov-action/pull/1867) > * fix: update to use local app/ dir by [`@thomasrockhu-codecov`](https://github.com/thomasrockhu-codecov) in [codecov/codecov-action#1872](https://redirect.github.com/codecov/codecov-action/pull/1872) > * docs: fix typo in README by [`@datalater`](https://github.com/datalater) in [codecov/codecov-action#1866](https://redirect.github.com/codecov/codecov-action/pull/1866) > * Document a `codecov-cli` version reference example by [`@webknjaz`](https://github.com/webknjaz) in [codecov/codecov-action#1774](https://redirect.github.com/codecov/codecov-action/pull/1774) > * build(deps): bump github/codeql-action from 3.28.18 to 3.29.9 by `@app/dependabot` in [codecov/codecov-action#1861](https://redirect.github.com/codecov/codecov-action/pull/1861) > * build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2 by `@app/dependabot` in [codecov/codecov-action#1833](https://redirect.github.com/codecov/codecov-action/pull/1833) > > **Full Changelog**: <https://github.com/codecov/codecov-action/compare/v5.5.0..v5.5.1> > > v5.5.0 > ------ > > ### What's Changed > > * feat: upgrade wrapper to 0.2.4 by [`@jviall`](https://github.com/jviall) in [codecov/codecov-action#1864](https://redirect.github.com/codecov/codecov-action/pull/1864) > * Pin actions/github-script by Git SHA by [`@martincostello`](https://github.com/martincostello) in [codecov/codecov-action#1859](https://redirect.github.com/codecov/codecov-action/pull/1859) > * fix: check reqs exist by [`@joseph-sentry`](https://github.com/joseph-sentry) in [codecov/codecov-action#1835](https://redirect.github.com/codecov/codecov-action/pull/1835) > * fix: Typo in README by [`@spalmurray`](https://github.com/spalmurray) in [codecov/codecov-action#1838](https://redirect.github.com/codecov/codecov-action/pull/1838) > * docs: Refine OIDC docs by [`@spalmurray`](https://github.com/spalmurray) in [codecov/codecov-action#1837](https://redirect.github.com/codecov/codecov-action/pull/1837) > * build(deps): bump github/codeql-action from 3.28.17 to 3.28.18 by `@app/dependabot` in [codecov/codecov-action#1829](https://redirect.github.com/codecov/codecov-action/pull/1829) > > **Full Changelog**: <https://github.com/codecov/codecov-action/compare/v5.4.3..v5.5.0> > > v5.4.3 > ------ > > ### What's Changed > > * build(deps): bump github/codeql-action from 3.28.13 to 3.28.17 by `@app/dependabot` in [codecov/codecov-action#1822](https://redirect.github.com/codecov/codecov-action/pull/1822) > * fix: OIDC on forks by [`@joseph-sentry`](https://github.com/joseph-sentry) in [codecov/codecov-action#1823](https://redirect.github.com/codecov/codecov-action/pull/1823) > > **Full Changelog**: <https://github.com/codecov/codecov-action/compare/v5.4.2..v5.4.3> > > v5.4.2 > ------ ... (truncated) Commits * [`1af5884`](codecov/codecov-action@1af5884) chore(release): bump to 5.5.3 ([#1922](https://redirect.github.com/codecov/codecov-action/issues/1922)) * [`c143300`](codecov/codecov-action@c143300) build(deps): bump actions/github-script from 7.0.1 to 8.0.0 ([#1874](https://redirect.github.com/codecov/codecov-action/issues/1874)) * See full diff in [compare view](codecov/codecov-action@671740a...1af5884) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
What does this PR do?
This PR fixes a null pointer handling issue in the
MethodCall.execute()method. When executing method parameters, the code now properly handles the case where the target object isnullby executing the expression with anullIdentifiable argument, instead of throwing aCommandExecutionException.Motivation
The existing code did not account for scenarios where
targetObjectscould benullwhen executing method call parameters. This caused failures in complex SQL queries that useLETclauses with string methods (likereplace()andILIKE()) in combination withUNIONALL()operations. The fix ensures that null values are properly propagated through method parameter evaluation.Related issues
N/A
Additional Notes
The test case
queryUnionAllWithLetAndStringMethods()demonstrates the scenario that was failing: a query usingLETto define variables with chained string method calls (replace()operations) followed byUNIONALL()to combine results. The fix allows these expressions to evaluate correctly when intermediate values are null.Checklist
mvn clean packagecommandhttps://claude.ai/code/session_019HJhUeYmAHEL2wx5monhz9