Skip to content

[Fix] Support for plot height below MIN_WORLD_HEIGHT #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Cinnazeyy merged 1 commit into from
Apr 3, 2025
Merged

[Fix] Support for plot height below MIN_WORLD_HEIGHT #157

Cinnazeyy merged 1 commit into from
Apr 3, 2025

Conversation

@tintinkung
Copy link
Contributor

@tintinkung tintinkung commented Apr 2, 2025

Support for all Terra server y level

Plot-System/src/main/java/com/alpsbte/plotsystem/core/system/plot/world/CityPlotWorld.java

Line 107 in a994eb7

if (plotHeight < MIN_WORLD_HEIGHT) throw new IOException("Plot height is not supported");

  • Fix fatal exception for plots below MIN_WORLD_HEIGHT by clamping height to 0

  • Previously, any plot saved with a Y level below MIN_WORLD_HEIGHT caused a fatal exception, making it impossible to generate. This is fixed by snapping out-of-bound plots to MIN_WORLD_HEIGHT, therefore getWorldHeight() returns 0 in such cases.

  • Alternatively, getWorldHeight() could directly return 0 to prevent the issue.

dev notes:

  • This is a very simple fix perhaps this pr wont even need to get merge, just decide it when you guys want to fix this bug.
  • I just finished setting up asean bte plot server for 1.21 and this issue has always been here, better if this get fix to main repo some day.
  • I tested the plot pasting mechanism and this fix would get handled by PlotUtil code very well i dont see any concerning bug at all.
  • ⚠️ one bug i saw is an edge case where a plot is saved at the lowest build limit, then plot schematic and environment schematic doesnt get paste of the same level.
  • this also fixes opening issue here: [Bug] - Plots are useless when height is below zero  #123 [Bug] - [23:06:33 ERROR]: An error occurred while generating plot! #109

@tintinkung
fix: support for plot height below MIN_WORLD_HEIGHT
f154299 
* Fix fatal exception for plots below MIN_WORLD_HEIGHT by clamping height to 0

* Previously, any plot saved with a Y level below MIN_WORLD_HEIGHT caused a fatal exception, making it impossible to generate. This is fixed by snapping out-of-bound plots to MIN_WORLD_HEIGHT, ensuring getWorldHeight() returns 0 in such cases. 

* Alternatively, getWorldHeight() could directly return 0 to prevent the issue."
Cinnazeyy
Cinnazeyy approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Cinnazeyy Cinnazeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! :)

@Cinnazeyy Cinnazeyy merged commit caaf702 into AlpsBTE:main Apr 3, 2025
1 check passed
This was referenced Apr 3, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cinnazeyy Cinnazeyy Cinnazeyy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tintinkung @Cinnazeyy