Code Cleanup #113
Merged
Code Cleanup #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cinnazeyy
added
the
rework
LordTuxn
requested changes
Mar 18, 2023
Collaborator
LordTuxn
left a comment
LordTuxn
left a comment
There was a problem hiding this comment.
I tested the plugin a bit and some menus/commands no longer work properly. All changes need to be tested on the server before merging.
| } | ||
| } else { | ||
| if(!sender.hasPermission(getPermission())) { | ||
| sender.sendMessage(Utils.getErrorMessageFormat("You don't have permission to use this command!")); |
Member
Author
There was a problem hiding this comment.
There wasn't any translation to begin with and i only fixed formatting! Also, to my knowledge this command has been on the "maybe-to-be-deleted-list" anyways, so i'm not sure if changing it is really necessary.
| player.sendMessage(Utils.getInfoMessageFormat("Successfully updated hologram location!")); | ||
| player.playSound(player.getLocation(), Utils.Done,1,1); | ||
| if (!sender.hasPermission(getPermission())){ | ||
| sender.sendMessage(Utils.getErrorMessageFormat("You don't have permission to use this command!")); |
Member
Author
There was a problem hiding this comment.
same here, the goal of this PR is only to cleanup the whole code structure, not to change any logic
| return true; | ||
| } | ||
|
|
||
| String[] splitCoords = args[0].split(","); |
Member
Author
There was a problem hiding this comment.
fixed in latest commit!
# Conflicts: # src/main/java/com/alpsbte/plotsystem/commands/CMD_Companion.java # src/main/java/com/alpsbte/plotsystem/commands/CMD_Plots.java # src/main/java/com/alpsbte/plotsystem/commands/CMD_Spawn.java # src/main/java/com/alpsbte/plotsystem/commands/CMD_Tpll.java # src/main/java/com/alpsbte/plotsystem/commands/admin/CMD_CleanPlot.java # src/main/java/com/alpsbte/plotsystem/commands/admin/CMD_DeletePlot.java # src/main/java/com/alpsbte/plotsystem/commands/admin/CMD_PReload.java # src/main/java/com/alpsbte/plotsystem/commands/admin/CMD_SetLeaderboard.java # src/main/java/com/alpsbte/plotsystem/commands/admin/setup/CMD_Setup_BuildTeam.java # src/main/java/com/alpsbte/plotsystem/commands/admin/setup/CMD_Setup_City.java # src/main/java/com/alpsbte/plotsystem/commands/admin/setup/CMD_Setup_Country.java # src/main/java/com/alpsbte/plotsystem/commands/admin/setup/CMD_Setup_Difficulty.java # src/main/java/com/alpsbte/plotsystem/commands/admin/setup/CMD_Setup_FTP.java # src/main/java/com/alpsbte/plotsystem/commands/admin/setup/CMD_Setup_Server.java # src/main/java/com/alpsbte/plotsystem/commands/plot/CMD_Plot_Submit.java # src/main/java/com/alpsbte/plotsystem/commands/plot/CMD_Plot_UndoSubmit.java # src/main/java/com/alpsbte/plotsystem/commands/review/CMD_EditFeedback.java # src/main/java/com/alpsbte/plotsystem/commands/review/CMD_EditPlot.java # src/main/java/com/alpsbte/plotsystem/commands/review/CMD_Review.java # src/main/java/com/alpsbte/plotsystem/commands/review/CMD_UndoReview.java # src/main/java/com/alpsbte/plotsystem/core/holograms/HologramManager.java # src/main/java/com/alpsbte/plotsystem/core/holograms/HolographicDisplay.java # src/main/java/com/alpsbte/plotsystem/core/holograms/ScoreLeaderboard.java # src/main/java/com/alpsbte/plotsystem/core/menus/AbstractMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/FeedbackMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/PlotActionsMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/PlotMemberMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/ReviewMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/ReviewPlotMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/companion/CityProjectMenu.java # src/main/java/com/alpsbte/plotsystem/core/menus/companion/CompanionMenu.java # src/main/java/com/alpsbte/plotsystem/core/system/Builder.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/Plot.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/PlotHandler.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/PlotManager.java # src/main/java/com/alpsbte/plotsystem/core/system/plot/PlotType.java # src/main/java/com/alpsbte/plotsystem/core/system/tutorial/stage/tasks/message/RemoveHologramTask.java # src/main/java/com/alpsbte/plotsystem/utils/Utils.java # src/main/java/com/alpsbte/plotsystem/utils/io/YamlFileFactory.java # src/main/java/com/alpsbte/plotsystem/utils/io/config/ConfigUtil.java # src/main/java/com/alpsbte/plotsystem/utils/io/language/LangUtil.java # src/main/java/com/alpsbte/plotsystem/utils/items/SpecialBlocks.java # src/main/java/com/alpsbte/plotsystem/utils/items/builder/ItemBuilder.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #112