Skip to content

Finder tuned: prefiltering for performance#4452

Merged
jgrosseo merged 2 commits intoAliceO2Group:devfrom
ddobrigk:dev
Sep 28, 2020
Merged

Finder tuned: prefiltering for performance#4452
jgrosseo merged 2 commits intoAliceO2Group:devfrom
ddobrigk:dev

Conversation

@ddobrigk
Copy link
Contributor

No description provided.

@ddobrigk ddobrigk requested a review from jgrosseo as a code owner September 26, 2020 12:17
@jgrosseo
Copy link
Collaborator

@davidrohr @sawenzel If we want analyzers to consider the output of the checkcode test without our help, we have to improve its output. I don't even find the problem in the checkcode output in this PR. Could you let me know?
I propose we redo the output in a way, that the errors are printed at the beginning, and ideally the full build output goes to a different file where we just indicate the link. What do you think about this?

jgrosseo
jgrosseo previously approved these changes Sep 27, 2020
@jgrosseo
Copy link
Collaborator

ps - In case it is a false positive, please merge.

@davidrohr
Copy link
Collaborator

davidrohr commented Sep 27, 2020 via email

@ddobrigk
Copy link
Contributor Author

So, if I understand correctly this PR failed the o2checkcode because of me not adding underscores before capital letters in the middle of the names of table columns - is that it? ...

@sawenzel
Copy link
Collaborator

@jgrosseo : Like for other builds the output shown is the complete log of the build process (I usually grep for "error"). In order to make this appear at the top or having it stand out, one would need to do adjustments in the CI logic I believe.

@sawenzel
Copy link
Collaborator

@ddobrigk : Yes, the rule for namespaces (as described here https://github.com/AliceO2Group/CodingGuidelines/blob/master/naming_formatting.html) is Namespace names follow underscore convention and start with a lower case letter: <code>my_namespace</code>.

@ddobrigk
Copy link
Contributor Author

@jgrosseo @sawenzel now changed to stick to naming convention. Thanks!

@jgrosseo jgrosseo merged commit ec7f38d into AliceO2Group:dev Sep 28, 2020
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments