Add Python 3.12 to wheels generation #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstone-lucasfilm
changed the title
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
May 7, 2024
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @howetuft!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highest version of Python for generating wheels in the Github workflow is currently 3.11. However, Python 3.12 is now quite widespread (Ubuntu 24.04, Arch Linux, Windows etc.). On a platform with Python 3.12,
pip installresults in recompilation from source, which is quite tedious.The proposal is therefore simply to extend the generation of wheels in the Github workflow to Python 3.12, to feed PyPI.
Thank you in advance!