Deterministic code generation #1376
Conversation
|
Thanks for this fix, @SShikhali, and let us know if you run into trouble with the EasyCLA process. The Linux Foundation is usually very responsive if you submit a support ticket using the links above. |
|
@jstone-lucasfilm should be fixed now, thanks :) |
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for putting this fix together, @SShikhali!
To make sure we don't lose any efficiency with respect to the original version, it may be better to maintain both a vector and a set, as in the following:
std::set<ShaderNode*> usedNodeSet;
std::vector<ShaderNode*> usedNodeVec;
This would allow us to efficiently maintain a vector of unique nodes with logic like the following:
ShaderNode* node = edge.upstream->getNode();
if (usedNodeSet.count(node) == 0)
{
usedNodeSet.insert(node);
usedNodeVec.push_back(node);
}
An at the end of the function, we could then simply replace the resize and assign calls with the following:
_nodeOrder = usedNodeVec;
|
@jstone-lucasfilm yes, that's better. Pushed the improved version |
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @SShikhali!
I'm CC'ing @niklasharrysson for his thoughts before we merge, but I don't have any concerns on my side.
niklasharrysson
left a comment
niklasharrysson
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the fix @SShikhali
These changes make code generation deterministic by changing std::set to std::vector when removing unused nodes
3 participants
These changes make code generation deterministic by changing
std::settostd::vectorwhen removing unused nodes