Grant required IAM roles to Compute Engine default SA when --managed-mldiagnostics is passed during xpk cluster create#1187
Open
rapatchi wants to merge 1 commit into
Open
Conversation
rapatchi
requested review from
FIoannides,
SikaGrr,
jamOne-,
scaliby and
stony-tark
as code owners
scaliby
requested changes
Jun 10, 2026
…agnostics When provisioning clusters with --managed-mldiagnostics, XLA ML diagnostics requires roles/hypercomputecluster.editor, roles/storage.objectUser, and roles/logging.logWriter to be bound to the Compute Engine default service account. This commit: 1. Automatically resolves projectNumber and grants these 3 IAM roles via gcloud projects add-iam-policy-binding during cluster create when --managed-mldiagnostics is enabled. 2. Explicitly specifies --condition=None to ensure non-interactive command compatibility when existing IAM policies contain conditional bindings. 3. Updates user documentation (permissions.md, clusters.md) and unit test coverage accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When provisioning clusters with
--managed-mldiagnostics, XLA ML diagnostics requiresroles/hypercomputecluster.editor,roles/storage.objectUser, androles/logging.logWriterto be bound to the Compute Engine default service account.This commit:
gcloud projects add-iam-policy-bindingduring cluster create when--managed-mldiagnosticsis enabled.Issue
If not done permissions need to be given manually for mldiagonstics to work.
Testing
Have you performed any manual testing on your change?
Prior IAM Bindings:
Cluster Creation Logs:
Post Creation:
Have you verified use cases affected by goldens? Yes