Fix false positive 'passedByValue' when address of argument is used

danmar · danmar · commit 655a8b21b6f1 · 2018-06-23T23:25:06.000+02:00
diff --git a/lib/checkother.cpp b/lib/checkother.cpp
@@ -1385,6 +1385,9 @@ static bool canBeConst(const Variable *var)
                     if (!argVar|| (!argVar->isConst() && argVar->isReference()))
                         return false;
                 }
+            } else if (parent->str() == "&" && !parent->astOperand2()) {
+                // TODO: check how pointer is used
+                return false;
             } else if (parent->isConstOp())
                 ;
             else if (parent->isAssignmentOp()) {
diff --git a/test/testother.cpp b/test/testother.cpp
@@ -1557,6 +1557,12 @@ class TestOther : public TestFixture {
               "}");
         ASSERT_EQUALS("", errout.str());
 
+        check("void foo(std::string* str);\n"
+              "void f(std::string str) {\n"
+              "    foo(&str);\n"
+              "}");
+        ASSERT_EQUALS("", errout.str());
+
         check("void foo(int& i1, const std::string& str, int& i2);\n"
               "void f(std::string str) {\n"
               "    foo((a+b)*c, str, x);\n"

Original file line number	Diff line number	Diff line change
`@@ -1385,6 +1385,9 @@ static bool canBeConst(const Variable *var)`
`1385`	`1385`	`if (!argVar\|\| (!argVar->isConst() && argVar->isReference()))`
`1386`	`1386`	`return false;`
`1387`	`1387`	`}`
	`1388`	`+ } else if (parent->str() == "&" && !parent->astOperand2()) {`
	`1389`	`+ // TODO: check how pointer is used`
	`1390`	`+ return false;`
`1388`	`1391`	`} else if (parent->isConstOp())`
`1389`	`1392`	`;`
`1390`	`1393`	`else if (parent->isAssignmentOp()) {`