Skip to content

fix(ssl): prevent domain loss when editing certificate remark#10946

Merged
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@ssl
Nov 13, 2025
Merged

fix(ssl): prevent domain loss when editing certificate remark#10946
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@ssl

Conversation

@zhengkunwang223

@zhengkunwang223 zhengkunwang223 commented Nov 13, 2025

Copy link
Copy Markdown
Member

Refs #10944

@f2c-ci-robot

f2c-ci-robot Bot commented Nov 13, 2025

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot

f2c-ci-robot Bot commented Nov 13, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud

sonarqubecloud Bot commented Nov 13, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@wanghe-fit2cloud wanghe-fit2cloud merged commit a70e263 into dev-v2 Nov 13, 2025
4 of 6 checks passed
@wanghe-fit2cloud wanghe-fit2cloud deleted the pr@dev-v2@ssl branch November 13, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssongliu ssongliu Awaiting requested review from ssongliu
@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

Assignees

No one assigned

Labels

dev-v2 do-not-merge/release-note-label-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhengkunwang223 @wanghe-fit2cloud @1Panel-bot