fix: fix CopyRequestBuilder.post() to not expect a response#830
Closed
aberezh wants to merge 1 commit intomicrosoftgraph:mainfrom
Closed
fix: fix CopyRequestBuilder.post() to not expect a response#830aberezh wants to merge 1 commit intomicrosoftgraph:mainfrom
aberezh wants to merge 1 commit intomicrosoftgraph:mainfrom
Conversation
The method was expecting a `DriveItem` as a response, while the `driveitem_copy` REST API doesn't return anything - https://learn.microsoft.com/en-us/onedrive/developer/rest-api/api/driveitem_copy#response microsoftgraph#334
baywet
requested changes
Jul 29, 2024
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Hi @aberezh,
Thank you for your contribution.
Unfortunately, we cannot accept it because it targets parts of a code that are auto generated.
This means that next weekly generation it would get overwritten.
But this gets generated from the service metadata we process and if we fix the metadata information we would be able to generate the right method prototype.
Can you open a new issue in this repository so we can start looking into fixing the metadata please?
https://GitHub.com/Microsoftgraph/msgraph-metadata
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CopyRequestBuilder.post()method was expecting aDriveItemas a response, while thedriveitem_copyREST API doesn't return anything - https://learn.microsoft.com/en-us/onedrive/developer/rest-api/api/driveitem_copy#response#334